After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548380 - Character count message needs reordering in translation
Character count message needs reordering in translation
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: i18n
2.23.x
Other All
: Normal trivial
: 2.24.0
Assigned To: Willie Walker
Depends on:
Blocks:
 
 
Reported: 2008-08-19 05:25 UTC by Theppitak Karoonboonyanan
Modified: 2009-03-10 00:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Add var names to format string (740 bytes, patch)
2008-08-19 05:26 UTC, Theppitak Karoonboonyanan 		none Details | Review
Updated patch (885 bytes, patch)
2008-08-20 00:13 UTC, Willie Walker 		committed Details | Review

Description Theppitak Karoonboonyanan 2008-08-19 05:25:31 UTC 
#: ../src/orca/default.py:6289
#, python-format
msgid "%d %s character"
msgid_plural "%d %s characters"

For some languages, including Thai, this needs reordering in translation, like:

  "อักขระ %s %d ตัว" (literally "character %s %d entries").

So, variable names in format string are required here.
Comment 1 Theppitak Karoonboonyanan 2008-08-19 05:26:52 UTC 
Created attachment 116928 [details] [review]
Add var names to format string
Comment 2 Willie Walker 2008-08-20 00:13:17 UTC 
Created attachment 117019 [details] [review]
Updated patch

The original patch didn't work well on my machine, but it gave me the general idea of what you wanted to do (thanks!).  Here's a patch that produces the desired behavior, I think.   Please try it out --- if it's OK, I'll check it in and send out a string change announcement.
Comment 3 Theppitak Karoonboonyanan 2008-08-20 05:29:35 UTC 
Ah, yes. My previous patch was untested. Sorry.

I haven't tested your patch by directly getting the code portion run, but by copying it somewhere else that is easier to invoke (it's under '--version' command line option actually) and trying out the translation. And it works.
Comment 4 Willie Walker 2008-08-20 14:26:10 UTC 
Thanks!  Committed for Orca v2.23.91.  String change message also sent to appropriate lists.  Closing as FIXED.