After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548308 - "Show previous conversations" segfaults when there is no account
"Show previous conversations" segfaults when there is no account
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal major
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2008-08-18 17:10 UTC by Frederic Peters
Modified: 2008-08-20 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check there is a selected account (584 bytes, patch)
2008-08-18 17:11 UTC, Frederic Peters 		committed Details | Review

Description Frederic Peters 2008-08-18 17:10:43 UTC 
Just start Empathy the first time; skip the account creation dialog; and select "show previous conversations".  Empathy crashes.

Note it was reported in Ubuntu but not forwarded upstream <https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/256796>.
Comment 1 Frederic Peters 2008-08-18 17:11:30 UTC 
Created attachment 116886 [details] [review]
check there is a selected account

Check there is a selected item before accessing its iter.
Comment 2 Xavier Claessens 2008-08-20 08:44:21 UTC 
Great!

Just little coding style: no space required after the ! and the if statement needs brackets even for one line:
if (foo) {
        bar;
}

I mark the patch as accepted anyway :)
Comment 3 Frederic Peters 2008-08-20 08:54:44 UTC 
Thanks, fixed the issues and commited.