GNOME Bugzilla – Bug 548083
Kill CPP_NOSTDINC
Last modified: 2009-10-28 19:25:55 UTC
This bug is a followup to Bug 536044. Sometimes on Linux when using gcc, the macro CPP_NOSTDINC is set to '-I-'. That string is sent as an option to the preprocessor (gcc -E) to "ignore standard include paths." But that is not what that option does (see http://www.redhat.com/docs/manuals/enterprise/RHEL-3-Manual/gcc/directory-options.html) and on the actual command line sent to gcc -E it has basically no effect whatsoever. And no one seem to know why that option is there, see http://mail.gnome.org/archives/orbit-list/2001-December/msg00052.html. So here is a patch to remove that code.
Created attachment 116774 [details] [review] Remove unnecessary code for pointless CPP_NOSTDINC macro
Michael, can we commit this now?
Well - sure, I guess for gcc perhaps there is no problem; but is this just gcc specific ? we have to run on top of angst-ridden compilers like the SunFoo thing - Brian - does this work for you ?
I tested this with the Intel compiler and it compiles at least. Not sure how to test if it really works.
Michael, I applied this patch to our libIDL on Solaris, ran aclocal, automake, autoconf, configure, make, make install. Then I built ORBit2 and libbonobo after making this change. Everything seemed to work fine using the latest Sun Studio 12 compiler. I didn't test older versions of Sun Studio/Forte, but moving forward we should only need to support Sun Studio 12 anyway. You don't really specify what tests you wanted me to run, so let me know if there is any additional tests I should run to ensure this works well. If these tests are sufficient, then I think it's okay from Sun Studio's perspective. Thanks for letting me check into this, and God bless.
Brilliant - thanks for the check Brian, and the cruft cleanup Bjorn. Kjartan - any chance of getting it committed too ? ;-) /me is of course the worlds most lazy person.
Commited.