After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547842 - Vorbis RTP RFC 5215 is out
Vorbis RTP RFC 5215 is out
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.11
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-14 21:36 UTC by Olivier Crête
Modified: 2008-08-15 17:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to update the vorbis rtp pay/depay to RFC 5215 (5.58 KB, patch)
2008-08-14 21:37 UTC, Olivier Crête
committed Details | Review

Description Olivier Crête 2008-08-14 21:36:40 UTC
I'm attaching a patch that updates the rtp pay/depay to the final RFC. There are not many changes from the last draft, the only thing I could see is that "delivery-method" and "configuration-uri" are definitely gone. Also, it should not reject caps that don't have a configuration set, in that case, it may come in the data stream, so it will drop all data buffers that come before the config has been set.

Patch attached
Comment 1 Olivier Crête 2008-08-14 21:37:20 UTC
Created attachment 116615 [details] [review]
patch to update the vorbis rtp pay/depay to RFC 5215
Comment 2 Wim Taymans 2008-08-15 17:26:31 UTC
        Patch by: Olivier Crete <tester at tester dot ca>

        * gst/rtp/gstrtpvorbisdepay.c: (gst_rtp_vorbis_depay_setcaps),
        (gst_rtp_vorbis_depay_process):
        * gst/rtp/gstrtpvorbispay.c: (gst_rtp_vorbis_pay_finish_headers):
        Update the vorbis RTP pay/depay to RFC 5215.
        Fixes #547842.