After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547725 - Banshee's first run from the menu icon doesn't start
Banshee's first run from the menu icon doesn't start
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other All
: Normal critical
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 550097 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-14 08:49 UTC by Chow Loong Jin
Modified: 2008-08-31 20:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds a mkdir -p $HOME/.config/banshee-1 on first start. (356 bytes, patch)
2008-08-14 08:53 UTC, Chow Loong Jin
none Details | Review
A better approach to the issue. (364 bytes, patch)
2008-08-14 09:07 UTC, Chow Loong Jin
none Details | Review
Add quotes (367 bytes, patch)
2008-08-14 09:16 UTC, Chow Loong Jin
committed Details | Review

Description Chow Loong Jin 2008-08-14 08:49:10 UTC
Steps to reproduce:
1. Click on Applications->Sound and Video->Banshee Media Player
2. There is no response (The bash script /usr/bin/banshee-1 dies)


Stack trace:


Other information:
banshee-1.desktop executes Banshee with --redirect-log. This directs the log in the Bash script itself, to ~/.config/banshee-1/log. However, during the first run, ~/.config/banshee-1 doesn't exist, and hence redirection fails and Banshee doesn't start. I've produced a patch which I'll attach shortly.
Comment 1 Chow Loong Jin 2008-08-14 08:53:06 UTC
Created attachment 116552 [details] [review]
Adds a mkdir -p $HOME/.config/banshee-1 on first start.
Comment 2 Chow Loong Jin 2008-08-14 08:59:40 UTC
Comment on attachment 116552 [details] [review]
Adds a mkdir -p $HOME/.config/banshee-1 on first start.

Index: src/Clients/banshee-1.in
===================================================================
--- src/Clients/banshee-1.in	(revision 4367)
+++ src/Clients/banshee-1.in	(working copy)
@@ -42,6 +42,7 @@
 if [ -z "$BANSHEE_REDIRECT_LOG" ]; then
 	exec $exec_args
 else
+	mkdir -p $`dirname $BANSHEE_REDIRECT_LOG`
 	exec $exec_args &> $BANSHEE_REDIRECT_LOG
 fi
Comment 3 Chow Loong Jin 2008-08-14 09:07:11 UTC
Created attachment 116553 [details] [review]
A better approach to the issue.
Comment 4 Chow Loong Jin 2008-08-14 09:16:06 UTC
Created attachment 116556 [details] [review]
Add quotes
Comment 5 Bertrand Lorentz 2008-08-14 20:27:13 UTC
Looks good to me, but I'm no bash guru.
Comment 6 Aaron Bockover 2008-08-15 00:39:43 UTC
Committed, thanks!
Comment 7 Bertrand Lorentz 2008-08-31 20:32:00 UTC
*** Bug 550097 has been marked as a duplicate of this bug. ***