After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547443 - crashes on desktop parsing errors
crashes on desktop parsing errors
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
2.25.x
Other Linux
: Normal critical
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-12 15:19 UTC by Sebastien Bacher
Modified: 2009-06-29 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
correcly set the gerror variable (812 bytes, patch)
2008-08-12 15:23 UTC, Sebastien Bacher
none Details | Review
backtrace (2.87 KB, text/plain)
2009-03-25 09:15 UTC, Laurent Bigonville
  Details
avoid crashes on desktop parsing errors (400 bytes, patch)
2009-06-14 21:22 UTC, gajdusek.petr
committed Details | Review

Description Sebastien Bacher 2008-08-12 15:19:29 UTC
the bug has been described on https://bugs.launchpad.net/ubuntu/+source/gnome-session/+bug/257250

"Binary package hint: gnome-session

After installing a large batch of updates, gnome-session 2.23.6-0ubuntu1 crashes reproducibly for me on every login, after about 10 seconds or so. I can see that nautilus has started successfully, and the log indicates that compiz is running, but it's before the panel starts.

I will attach my .xsession-errors and attempt to get a stack trace (apport did not trigger for some reason)

http://launchpadlibrarian.net/16724201/failed-login-xsession-errors"


The issue is that the parser doesn't handle False as a correct value and crashes because the GError is not correctly set
Comment 1 Sebastien Bacher 2008-08-12 15:23:24 UTC
Created attachment 116431 [details] [review]
correcly set the gerror variable
Comment 2 William Jon McCann 2008-08-12 21:46:13 UTC
Fixed in trunk.  Thanks!
Comment 3 Laurent Bigonville 2009-01-23 15:05:55 UTC
Reopening this bug as I'm hit by it with gnome-session version 2.25.5
Comment 4 Vincent Untz 2009-03-25 01:34:38 UTC
Laurent: if you can still see the crash, can you attach a stack trace?
Comment 5 Laurent Bigonville 2009-03-25 09:15:48 UTC
Created attachment 131324 [details]
backtrace
Comment 6 gajdusek.petr 2009-06-14 21:14:15 UTC
I have same crashes, my patch is available at bugs.debian.org, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=532702

I just reverted some recent upstream changes that in my opinion caused this crash. Please note that I am not familiar with C, glib or gnome programming, so please review this patch well. I am also not sure what reason had this particularly change in the upstream code. If it was not only for better performance I probably missed something.

Cheers,
Petr
Comment 7 gajdusek.petr 2009-06-14 21:20:05 UTC
I forget to mention this bug is probably other bug then the bug already closed in this bugreport but it is sure the same bug Laurent Bigonville accounted.
Comment 8 gajdusek.petr 2009-06-14 21:22:56 UTC
Created attachment 136581 [details] [review]
avoid crashes on desktop parsing errors
Comment 9 Vincent Untz 2009-06-29 21:47:59 UTC
Thanks!