After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547434 - Provide a "Downloaded Items" view that shows all downloaded items at once.
Provide a "Downloaded Items" view that shows all downloaded items at once.
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Podcasting
1.2.0
Other All
: Normal enhancement
: 1.x
Assigned To: Mike Urbanski
Mike Urbanski
Depends on:
Blocks:
 
 
Reported: 2008-08-12 14:27 UTC by valentin.sawadski
Modified: 2008-09-06 22:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to implement the proposed feature request. (5.74 KB, patch)
2008-08-12 14:43 UTC, valentin.sawadski
needs-work Details | Review
Second Try to implement the feature. (20.76 KB, patch)
2008-08-15 08:42 UTC, valentin.sawadski
rejected Details | Review

Description valentin.sawadski 2008-08-12 14:27:32 UTC
At the moment it is pretty hard to check what podcasts where already downloaded and what not.

I suggest to add a simple "Downloaded Items" to the box in the Podcasts view where there is currently a "New Items" and "Old Items" selection.
Comment 1 valentin.sawadski 2008-08-12 14:43:13 UTC
Created attachment 116427 [details] [review]
Patch to implement the proposed feature request.
Comment 2 Brandan E. Lloyd 2008-08-12 16:56:55 UTC
I was able to patch and run the build successfully.

The downloaded list populates properly.  This is a nice feature, thanks Valentin.
Comment 3 Bertrand Lorentz 2008-08-14 21:56:59 UTC
Thanks for the patch !
It works nicely, but I have a few minor issues : 
- some line are indented with tabs, please use spaces instead.
See the HACKING file for the details.

- With your patch, the ColumnCellUnheard and the PodcastUnheardFilter* classes are not anymore only about unheard podcasts. They might need to be renamed. How about replacing Unheard with Status ?
Comment 4 valentin.sawadski 2008-08-15 08:42:31 UTC
Created attachment 116637 [details] [review]
Second Try to implement the feature.

Bertrand, thanks for your comments.

The second patch I hand in implements all you suggestions. Which means that:
- Tabs have been replaced by spaces.
- The corresponding files and classes have been renamed from Unheard to Status.
Comment 5 Gabriel Burt 2008-08-16 06:58:23 UTC
I like the idea of being able to browse/filter by download status, but this shouldn't be mixed in with the new/old filter - it should be in its own, separate filter, either above or below the new/old filter.
Comment 6 Gabriel Burt 2008-09-06 22:47:32 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.