GNOME Bugzilla – Bug 547373
occasional eog deadlocks
Last modified: 2019-02-22 14:22:32 UTC
We've had reports of eog occasionally hanging at startup. See https://bugzilla.redhat.com/show_bug.cgi?id=458158 I'll attach a stacktrace that shows that eog calls gtk functions in the thread executing the image-loading job without taking the gdk lock.
Created attachment 116394 [details] stacktrace
Created attachment 116397 [details] [review] a patch Here is an untested patch that may fix the issue. It is definitively right to take the lock earlier, since a) you are explicitly calling gtk functions in main() before taking the lock right now, and b) load_files() calls into gtk as well.
Some further testing reveals that the patch does not fix the issue. I also tried moving the load_files () call into the mainloop, and it didn't help either. The deadlocks happen relatively frequently under the following constellation: - a11y modules loaded - a11y registry not running When the registry is running, the deadlocks disappear. Looks like an a11y issue to me
I think gdk_threads_init and gdk_threads_enter should be called before gnome_program_init. The accessibility modules are loaded in gnome_program_init, that means some gtk calls happen in this function.
I tried that, it doesn't help. The problem is that when registryd is not running, I sometimes see the bridge code reenter spi_atk_bridge_register_application. Which is bad, because it gives a leave, leave, enter, enter sequence which obviously deadlocks on the second enter... So this is some sort of robustness problem. Meanwhile I've found that the registry is not running because the at-spi-registryd-wrapper in gnome-session is segfaulting...
Experiencing the same now, eog deadlocks if I open it in the command line with a directory full of pictures.
*** Bug 555959 has been marked as a duplicate of this bug. ***
[Resetting QA Contact to newly introduced "at-spi-maint@gnome.bugs". Reason: So far it was impossible to watch changes in at-spi bug reports without following all the specific persons (Li Yuan, Bill Haneman, Jeff Wai, ...) and also their activity outside of at-spi reports. IMPORTANT: Anyone interested in following all bug activity (including all maintainers) must watch the "at-spi-maint@gnome.bugs" dummy user by adding it to the 'Users to watch' list under Preferences->Email preferences. This is also the default procedure nowadays in GNOME when setting up new products.]
[Mass-resetting default assignee, see bug 705890. Please reclaim this bug report by setting the assignee to yourself if you still plan to work on this. Thanks!]
This problem was reported against a version which is not supported anymore. Could you please check again if the issue you reported here still happens in a recent version of GNOME and update this report by adding a comment, adjusting the 'Version' field, and resetting the status of this bug report from NEEDINFO to its previous status? Without feedback this report might get closed as INCOMPLETE after a while. Again thank you for reporting this problem. We are sorry that it could not be fixed for the version that you originally used here.
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment. Thanks!