GNOME Bugzilla – Bug 547308
Evolution tries to talk too much to the GAL server
Last modified: 2013-09-13 01:00:29 UTC
After recent change about being able to select authentication method for GAL from bug #500389, I changed the behavior in eds patch, chunk @@ -314,12 +315,25 @@ connect_ldap (E2kGlobalCatalog *gc, E2kO When the NTLM is forced to be used, and it is not supported (one doesn't compile with patched LDAP), then the result is repository offline, but in the addressbook.c is only check for some values of the result status in load_source_auth_cb, thus resulting to repo-offline it tries to poke with the server for ever. Quite bad.
Created attachment 116359 [details] [review] proposed evo patch for evolution; Do not try to authenticate to the server more than twice when knows the password and it didn't fail because of wrong user name/password. Anyway, I do not see any reason why to reauthenticate with known credentials. It doesn't make much sense to me. Can someone explain to me, please? Because I think there is some reason, I just miss it.
Created attachment 116371 [details] [review] proposed eds patch for evolution-data-server;
Created attachment 116373 [details] [review] proposed evo patch ][ for evolution;
Created attachment 116375 [details] [review] proposed eex patch for evolution-exchange; I realized I want a bit more than I did in the initial evo.patch, thus changing one public function prototype from the eds/servers/exchange, adding new E_BOOK_ERROR and mixing all together between all evo-family. New strings added too.
Seems fine to me. I think we need to libebook version, since you added a new entry to the enum.
eds part committed to trunk. Committed revision 9327. evo part committed to trunk. Committed revision 35964. eex part committed to trunk. Committed revision 1739. As we discussed on IRC, you'll take care of the change of the API version on libebook in time of the release. You'll not forget, hopefully :)