After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547270 - Make GtkHSV public
Make GtkHSV public
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-08-11 10:36 UTC by Michael Natterer
Modified: 2008-08-11 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch implementing the above (10.86 KB, patch)
2008-08-11 11:25 UTC, Michael Natterer
accepted-commit_now Details | Review

Description Michael Natterer 2008-08-11 10:36:50 UTC
As already mentioned in this thread on gtk-devel:

http://mail.gnome.org/archives/gtk-devel-list/2008-August/msg00071.html

I have prepared a patch to install the header and do
the needed changes mentioned in the mail.

Patch follows.
Comment 1 Michael Natterer 2008-08-11 11:25:08 UTC
Created attachment 116332 [details] [review]
Patch implementing the above
Comment 2 Tim Janik 2008-08-11 11:38:33 UTC
Thanks, looks good to me.
Comment 3 Matthias Clasen 2008-08-11 15:36:23 UTC
When I announced 2.13.6, I basically declared it api frozen. 
So we may want to hold off on this until 2.15
Comment 4 Michael Natterer 2008-08-11 15:55:54 UTC
Can't we consider this a bug fix? :)

After all the symbols were always public and can be used,
just with gross hackery.
Comment 5 Matthias Clasen 2008-08-11 19:47:49 UTC
Ok, I can be convinced.

Of course, the fact that this was already used also means that there is no point in api review, since we can't change it anyway...
Comment 6 Michael Natterer 2008-08-11 19:58:28 UTC
Thanks, fixed in SVN:

2008-08-11  Michael Natterer  <mitch@imendio.com>

	Bug 547270 – Make GtkHSV public

	* gtk/Makefile.am
	* gtk/gtk.h: install gtkhsv.h as public header (its symbols were
	always public anyway).

	* gtk/gtkhsv.h: add single-include guards, add class struct padding,
	seal the instance member, cleanup.

	* gtk/gtkhsv.c: center the widget in its allocation,
	add "Since: 2.14", cleanup.