GNOME Bugzilla – Bug 547213
Unespected resume after Play Queue ends
Last modified: 2009-03-30 14:44:39 UTC
When the queue of playing songs reaches its end, the return of the reproduction is in the first item of the last filtered view. This is a wried behavior for a playing queue. It would be more accurate to return to the following song in the last filtered view, that was going to be reproduced as next before the jump to the Play Queue instead, so not repeating the entire filtered view, but continuing with the reproduction. This is the most common way of treating playing queues. Example of the current behavior: I have the following filtered list: 1. song 1 2. song 2 3. song 3 While listening "song 2" I en-queue "song A" so after the reproduction of "song 2" I hear it, but, when "song A" finishes the reproductions returns to "song 1" while I would really expect to be "song 3" instead.
I think I can confirm this (at least I think the bug that I was about to report would have been a dupe of this). If you start listening to the Play Queue anywhere other than the first song, it jumps to the first song as soon as the song you're listening to finishes instead of continuing down the list. Strange.
Nevermind, I think my observation was a separate issue. I do think that Bug 548391 may be a dupe of this, though.
*** Bug 548391 has been marked as a duplicate of this bug. ***
Good catch Michael. (From bug 548391) > An additional case: I am playing from another source (e.g. Music Library, a > playlist). > 1. I add something to the play queue. > 2. When that song is done, the play queue starts. > 3. When the Play Queue is finished, playback should return to my previous > source (and pick up at the right song). > > In general, the play queue should remember what was happening when it started > and return there when finished.
I committed part of the fix to this problem - if you weren't playing from the prior playback source, then when the queue is empty, it will set it as the playback source but it _won't_ play from it.
And committed the fix to return playback to the song after the one we left off from.
Fantastic; thanks!
(In reply to comment #6) > And committed the fix to return playback to the song after the one we left off > from. For posterity, this is what Banshee will do in these two cases. Case 1: Banshee stopped, items added to the Queue: 1. When you press Play, Banshee will play items from the Queue. 2. When the Queue is empty, playback will stop. Case 2: Playback from a source (e.g. Music Library, a playlist), items added to the queue: 1. When the current song finishes, playback switches to the Queue. 2. When the Queue is empty, playback will return to the previous source. To stop playback when using the Queue, the only way I know to do that is to make sure Banshee is stopped before starting the Queue, which (for me) has meant restarting Banshee. Pausing will not work, because the playback source is still marked "active" when the Queue takes over.