After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 547211 - Duplicated mnemonic
Duplicated mnemonic
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 547455
Blocks:
 
 
Reported: 2008-08-10 23:11 UTC by Gil Forcada
Modified: 2013-09-28 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Gil Forcada 2008-08-10 23:11:51 UTC
Seems that _R is duplicated here:

msgid "_Remember password until you logout"

msgid "_Remember forever"
Comment 1 Carlos Garcia Campos 2008-08-11 16:31:31 UTC
evmountoperation is just a copy of gtkmountoperation. Reassigning to GTK+.
Comment 2 Matthias Clasen 2008-08-11 19:10:10 UTC
2008-08-11  Matthias Clasen  <mclasen@redhat.com>

        Bug 547211 – Duplicated mnemonic

        * gtk/gtkmountoperation.c: Change mnemonics around in
        the password dialog to avoid a conflict.
        Reported by Gil Forcada
Comment 3 Wouter Bolsterlee (uws) 2008-08-12 15:09:11 UTC
Quoting from the mail thread on gnome-i18n:

| From: Matthias Clasen
|
| _Forget password immediately  -> Forget password _immediately
| _Remember password until you logout  -> Remember password until you _logout
| _Remember forever  ->  Remember _forever


| From: Sven Neumann
| 
| These are not very well chosen. From the HIG:
| 
|   Also, it is better not to assign access keys to "thin" letters (such
|   as lowercase i or l), or letters with descenders (such as lowercase
|   g or y) unless it is unavoidable. The underline does not show up very
|   well on those characters in some fonts."
| 
| Perhaps you want to try to find some characters that are better suited?


| From: Matthias Clasen
|
| I think it is more important to  have mnemonics that actually have
| some mnemonic value, than picking them based on what renders best...


| From: Gian Mario Tagliaretti
| It not a matter of render best in terms of "nice looking", people with
| disabilities (sight problems like me for example) will find harder to
| discern some letters as Sven pointed out.


See http://mail.gnome.org/archives/gnome-i18n/2008-August/msg00205.html for the full thread.
Comment 4 Wouter Bolsterlee (uws) 2008-08-12 15:11:01 UTC
And then we have this IRC discussion:


16:53:24 < uws> mclasen: have you fixed up the wrong mnemonics already?
16:54:02 -!- calumb is now known as calAFK
16:54:07 < mclasen> uws: whats wrong ? and what are the 'right' mnemonics you want me to pick ?
16:54:09 < uws> mclasen: http://svn.gnome.org/viewvc/gtk+?rev=21073&view=rev
16:54:16 < uws> mclasen: there's been a reply on gnome-i18n
16:54:22 < uws> mclasen: with a reference to the HIG
16:54:30 < uws> MacGyver_: i, f, and l are too narrow
16:54:40 < uws> mnemonic underline will only be 1 pixel
16:54:56 < uws> sorry MacGyver_, meant mclasen 
16:55:07 < mclasen> uws: ithe response doesn't convince me
16:55:49 < uws> mclasen: They will go unnoticed
16:55:59 < uws> mclasen: that HIG statement says it all, right?
16:56:09 < mclasen> uws: the hig is not the bible...
16:56:39 < uws> mclasen: people with <100% sight don't see single pixels
16:56:59 < pterjan> mclasen: actually it is, but like the bible you need to think by yourself :)
16:57:11 < uws> mclasen: the _f is okay btw
16:57:50 < mclasen> uws: random letters in the middle of a word don't have mnemonic value...
16:58:01 < uws> mclasen: Remember password until you _logout   ->   Remember password until log_out     perhaps
16:58:10 < uws> mclasen: (why the "you"?)
16:58:47 < uws> mclasen: agreed, it's a tradeoff. but in any case _i and _l are unacceptable
16:58:57 < uws> mclasen: and below descenders as well
16:59:56 < mclasen> uws: feel free to ship a en translation that corrects my errors of judgement
17:00:10 < mclasen> uws: or write a pango patch that makes sure that underlines are at least 3 pixels
17:00:55 < uws> mclasen: come on, is this really how you are going to handle this?
17:01:06 < uws> mclasen: the simple fix for now is to just use other mnemonics
17:01:10 < uws> like ALL applictions do
17:01:22 < uws> but because you personally don't think so, you ignore alle comments?
17:01:25 * pterjan sees some _l in various menus of evolution (in French)
17:01:31 < uws> pterjan: that's a bug.
17:01:37 < pterjan> and _j
17:01:44 < uws> that as well then.
17:01:46 < mclasen> uws: you are the one who makes a big deal out of a minor thing
17:02:28 < uws> mclasen: Eh? Please see the thread on gnome-i18n. I am *not* one of the 2 persons who complained
17:02:44 < mclasen> uws: it is not as if the dialog becomes unusable because you overlook the underline...
17:03:05 < uws> mclasen: I'm just speaking up because I'm supposed to act on behalf of the   http://live.gnome.org/TranslationProject/CoordinationTeam
17:03:26 < uws> mclasen: And I thought a 1 minute irc conversation would get this sorted out.
17:03:41 < uws> Apparently I was wrong. But don't tell me that I'm making big fuss about nothing

Comment 5 Reinout van Schouwen 2008-08-12 15:20:58 UTC
This is much related to usability as well. The HIG writers didn't put that guideline there just because they thought is was fun to annoy developers. 

Comment 6 Matthias Clasen 2008-08-12 16:30:56 UTC
You choose to cite selectively from the HIG. It also says 

Use the first letter of the label, or of one of its other words if it has more than one.
Comment 7 Matthias Clasen 2008-08-12 19:55:51 UTC
See bug 547455 for the pango feature request that will make this discussion moot.
Comment 8 Wouter Bolsterlee (uws) 2008-08-12 21:06:12 UTC
(In reply to comment #6)
> You choose to cite selectively from the HIG. It also says 

Who is "you"? I didn't quote, I just copied mail from others (and clearly stated I did so). Anyway, bug 547455 looks promising.

Comment 9 Reinout van Schouwen 2009-01-06 12:54:57 UTC
(In reply to comment #8)

> Who is "you"? I didn't quote, I just copied mail from others (and clearly
> stated I did so). Anyway, bug 547455 looks promising.

And now Behdad marked it NOTABUG?! 

Comment 10 Timothy Arceri 2013-09-28 12:16:22 UTC
Its been almost 5 years I don't see the point of keeping the bug open so marking again as resolved.
Original issue is fixed. Secondary issue should be tracked in another bug if i and j are still not wide enough in recent versions on GTK.