After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546839 - Add special case for transparent entries (for gecko and others)
Add special case for transparent entries (for gecko and others)
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: general
2.15.x
Other Linux
: High minor
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-07 17:31 UTC by Benjamin Berg
Modified: 2008-08-18 19:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Before / After (6.81 KB, image/png)
2008-08-15 11:39 UTC, Michael Monreal
Details

Description Benjamin Berg 2008-08-07 17:31:52 UTC
So, https://bugzilla.mozilla.org/show_bug.cgi?id=405421 should be fixed soon this means that we should add workarounds to the themes/engines in GNOME.

The needed changes are (for all themes/engines that have rounded corners for entries/progress bar):
 1. Set GtkEntry::honors-transparent-bg-hint = TRUE in the theme
 2. Test for the attached data with g_object_get_data(widget, "transparent-bg-hint");
 3. If the returned value is not NULL, skip any background filling that is done.
Comment 1 Benjamin Berg 2008-08-07 17:34:01 UTC
I wonder whether it would be worth backporting this to current stable.
Comment 2 Michael Monreal 2008-08-07 18:21:10 UTC
Firefox 3.1 won't be in distributions before the first 2009 release (if at all) so there's probably another two gnome releases before that. But if other apps (NM was discussed, WebKit anyone?) will also pick this up it's probably worth porting back.
Comment 3 Michael Monreal 2008-08-07 18:45:42 UTC
WebKit will pick up the patch from mozilla: https://bugs.webkit.org/show_bug.cgi?id=20320
Comment 4 Marco Barisione 2008-08-07 18:46:15 UTC
WebKit uses gtk2drawing.c from mozilla, so fixing the bug there should be trivial. See https://bugs.webkit.org/show_bug.cgi?id=20320
Comment 5 Benjamin Berg 2008-08-14 23:00:07 UTC
I have added code for both the clearlooks and industrial engine and theme. I also updated the Clearlooks based themes in gnome-themes.

If anyone is running a new enough version of Firefox and is able to test it, I would like to hear about it. (I don't anything new enough myself right now.)
Comment 6 Michael Monreal 2008-08-15 11:39:03 UTC
Created attachment 116657 [details]
Before / After

I just tested this with the latest nightly build from mozilla.org, you can see how it looks in those before/after shots. Can anything be done about the area surrounding buttons/entries (which seems to be a shadow or something like that rendered on top of GTK's background).
Comment 7 Benjamin Berg 2008-08-18 19:31:30 UTC
I think this bug can be closed again now.