GNOME Bugzilla – Bug 546822
gstreamer doesn't tell gettext to output its translations in UTF-8
Last modified: 2008-08-07 16:21:52 UTC
currently, almost all bindtextdomain calls in the entire gstreamer stacks are missing bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8") call after. This missing call is causing gettext to return translated text in local encoding, which is not always UTF-8 (if locale used is not an UTF-8 locale). Since most applications are expecting UTF-8 strings from gstreamer, it can cause incorrect display, like in gnome-sound-properties 2.23.6 in french. I'm attaching patches fixing this issues for all various gstreamer tarballs.
Created attachment 116072 [details] [review] gstreamer0.10 part
Created attachment 116073 [details] [review] gs-plugins-base part
Created attachment 116074 [details] [review] gst-plugins-good part
Created attachment 116075 [details] [review] gst-plugins-bad part
Created attachment 116076 [details] [review] gst-plugins-ugly part
Thanks a lot for the patches! 2008-08-07 Tim-Philipp Müller <tim.muller at collabora co uk> Patch by: Frederic Crozat <fcrozat@mandriva.org> * gst/gst.c: (init_pre): Make sure gettext returns translations in UTF-8 encoding rather than in the current locale encoding (#546822). 2008-08-07 Tim-Philipp Müller <tim.muller at collabora co uk> Patch by: Frederic Crozat <fcrozat@mandriva.org> * ext/alsa/gstalsaplugin.c: (plugin_init): * ext/cdparanoia/gstcdparanoiasrc.c: (plugin_init): * ext/gnomevfs/gstgnomevfs.c: (plugin_init): * ext/ogg/gstoggdemux.c: (gst_ogg_demux_plugin_init): * gst-libs/gst/audio/gstbaseaudiosrc.c: (_do_init): * gst-libs/gst/pbutils/pbutils.c: (gst_pb_utils_init): * gst-libs/gst/tag/tags.c: (gst_tag_register_tags_internal): * gst/playback/gstdecodebin.c: (plugin_init): * gst/playback/gstdecodebin2.c: (gst_decode_bin_plugin_init): * gst/playback/gstplayback.c: (plugin_init): * gst/playback/gstqueue2.c: (plugin_init): * gst/playback/gsturidecodebin.c: (gst_uri_decode_bin_plugin_init): * sys/v4l/gstv4l.c: (plugin_init): Make sure gettext returns translations in UTF-8 encoding rather than in the current locale encoding (#546822). 2008-08-07 Tim-Philipp Müller <tim.muller at collabora co uk> Patch by: Frederic Crozat <fcrozat@mandriva.org> * ext/esd/gstesd.c: (plugin_init): * ext/flac/gstflac.c: (plugin_init): * ext/shout2/gstshout2.c: (plugin_init): * ext/wavpack/gstwavpack.c: (plugin_init): * sys/oss/gstossaudio.c: (plugin_init): * sys/v4l2/gstv4l2.c: (plugin_init): Make sure gettext returns translations in UTF-8 encoding rather than in the current locale encoding (#546822). 2008-08-07 Tim-Philipp Müller <tim.muller at collabora co uk> Patch by: Frederic Crozat <fcrozat@mandriva.org> * ext/dvdread/dvdreadsrc.c: (plugin_init): * ext/lame/gstlame.c: (plugin_init): * gst/asfdemux/gstasf.c: (plugin_init): Make sure gettext returns translations in UTF-8 encoding rather than in the current locale encoding (#546822). 2008-08-07 Tim-Philipp Müller <tim.muller at collabora co uk> Patch by: Frederic Crozat <fcrozat@mandriva.org> * ext/sndfile/gstsf.c: (plugin_init): * sys/dvb/gstdvbsrc.c: (gst_dvbsrc_plugin_init): * sys/oss4/oss4-audio.c: (plugin_init): Make sure gettext returns translations in UTF-8 encoding rather than in the current locale encoding (#546822).