GNOME Bugzilla – Bug 546444
Camel waits forever when downloading a msg from POP3 (SSL) when connection goes down
Last modified: 2013-09-14 16:52:30 UTC
Please describe the problem: The problem happens when while trying to get a message from a POP3 account with SSL security, the network connection suddenly is lost. Then the Camel SSL stream will perform a PR_Poll forever, because when the timeout of that function happens it returns 0 and in this case only errno is set to some value, but the loop will go on forever. Steps to reproduce: 1. try to open a message from a POP3 SSL account (better a big one) 2. while retrieving is going on, disconnect the machine from the network 3. camel will try to read forever (I tested this with Modest and tinymail (camel-lite), but the code is the same in this case for both Camel and tinymail (camel-lite) Actual results: Camel performs a PR_Poll forever Expected results: Camel should exit with a connection error Does this happen every time? Yes Other information:
Created attachment 115920 [details] [review] Patch that fixes the neverending poll This patch makes the function stream_read exit whenever that connection error happen. Maybe we could set a number of retries but IMHO it makes no sense in this case because we'll be waiting too much for the timeouts.
Reviewed and approved for Tinymail's camel-lite
Commit to trunk as well. Thanks for your patch.
Seems that they're taking too much time to give me an account in GNOME svn.
Patch committed to SVN trunk as r9361 http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=9361