GNOME Bugzilla – Bug 546312
Make the metadata writable before modifying it in rtpmanager
Last modified: 2008-08-05 09:42:51 UTC
gstrtpsession and gstrtpjitterbuffer modify the buffer metadata (respectively the offset and the timestamp) without making sure that no one else owns the buffer first.. Attached patch fixes that
Created attachment 115853 [details] [review] make the metadata writable before modifying it
I added the calls in slightly different places. Based on patch by: Olivier Crete <tester at tester dot ca> * gst/rtpmanager/gstrtpjitterbuffer.c: (gst_rtp_jitter_buffer_chain), (gst_rtp_jitter_buffer_loop): Make the buffer metadata writable before inserting it in the jitterbuffer because the jitterbuffer will modify the timestamps. * gst/rtpmanager/rtpjitterbuffer.c: Update method comment about requiring writable metadata on buffers. * gst/rtpmanager/rtpsession.c: (rtp_session_process_sr), (rtp_session_process_rtcp): Make the RTCP buffer metadata writable because we want to modify the metadata. Fixes #546312.