After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 546200 - spawning gcc doesn't work on windows
spawning gcc doesn't work on windows
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: general
0.3.x
Other All
: Normal normal
: ---
Assigned To: Jürg Billeter
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-04 09:23 UTC by Vlad Grecescu
Modified: 2008-08-10 13:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (487 bytes, patch)
2008-08-04 12:36 UTC, Jared Moore 		committed Details | Review

Description Vlad Grecescu 2008-08-04 09:23:12 UTC 
Please describe the problem:
AFAICT it is the captured output from pkg-config that contains a newline which must be stripped.
I made the following change in gobject/valaccodecompiler.vala at line 96:
cmdline += " " + pkgflags.strip ();

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Jared Moore 2008-08-04 12:36:47 UTC 
Created attachment 115818 [details] [review]
patch

I haven't tested this, just making sure that this shows up in the patch report.
Comment 2 Jürg Billeter 2008-08-10 13:37:25 UTC 
Thanks for the patch, it looks fine. Jared, you've already committed it accidentally in r1738, so I'll just close the bug.
Comment 3 Jared Moore 2008-08-10 13:45:33 UTC 
Ah, sorry about that. I must have forgotten to SVN revert after making the patch. :)