GNOME Bugzilla – Bug 546146
ASX Parsing is broken
Last modified: 2008-08-06 01:53:16 UTC
Please describe the problem: Asx radio stations doesn't work, since the parsing code for the xml is broken Steps to reproduce: 1. Add a asx-based radio station (http://www.radioeins.de/live.wax, http://player.nrj.fr/V4/nrj/nrj.asx) 2. Double-click on it Actual results: Nothing Expected results: The radio station should start playing Does this happen every time? yes Other information:
Created attachment 115793 [details] [review] patch for the ASX parsing There were two problems with the asx parsing. First of all, the condition for the while was wrong, and the code never entered the main loop. Besides this, the code expected lower-case tags, but the asx format, as defined by ms, is upper-cased. Since there are many lower-case and even mixed-case asx files in the web, I modified the code to recognise both cases.
Seems like a duplicate of bug 510782. I'll try to test your patch with the steps and station described there: http://www.wdr.de/wdrlive/media/wdr3-wm32.asx.
I think bug #510782 is more about being unable to handle the mms:// protocol. I'm marking this as duplicate of bug #545646, which was reported earlier and also has a patch. Sorry Félix, you'll have to bring your patch over to it. By the way, in your patch, I think that if (href == null || String.Compare("", href)==0) could be better written as if (String.IsNullOrEmpty (href)) *** This bug has been marked as a duplicate of 545646 ***
(In reply to comment #3) > I think bug #510782 is more about being unable to handle the mms:// protocol. The URL changed to the one I linked above, but the issue remained. Also, I've gotten yelled at before for marking bugs as duplicates with patches; the least we could do, when necessary, is download the patches and reupload them to the other bug. (I'll do that later on, can't at the moment.)
Patch obsoleted by commit from bug 545646.