After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545950 - cheese should ask to delete files if moving to trash fails
cheese should ask to delete files if moving to trash fails
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Filippo Argiolas
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-08-02 06:37 UTC by Filippo Argiolas
Modified: 2008-08-04 08:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
delete file if move to trash fails (5.59 KB, patch)
2008-08-03 08:18 UTC, Filippo Argiolas 		committed Details | Review

Description Filippo Argiolas 2008-08-02 06:37:32 UTC 
I have the xdg video dir in a fat32 partition and for some reason there is no trash dir there so when I try to remove items from the thumbview I just get an error complaining that they cannot be moved to the trash.

I think we should ask the user if he wants to permanently delete the file when g_file_trash fails.
Comment 1 Filippo Argiolas 2008-08-02 06:39:06 UTC 
Hey I've just seen there is a TODO note about this in the source code :P
Comment 2 Filippo Argiolas 2008-08-03 08:18:50 UTC 
Created attachment 115768 [details] [review]
delete file if move to trash fails

Attaching a patch. I think it's ready to commit so if nobody complains I'll commit it later today.
If you want to test it just run chmod -x .local/share/Trash (or your trash dir), to temporary disable the trash (chmod +x to restore it).
Backup your files and try Move to trash and Move all to trash actions.
I tried to resemble the usual nautilus behavior and strings.
TODO: add a shift key shortcut to bypass trash and delete directly to MoveToTrash and RemoveAll actions (still wondering how to do it, hints?)
Comment 3 Filippo Argiolas 2008-08-04 08:53:16 UTC 
Committed.