After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545782 - Please include a *_construct() function for GstAudioClock
Please include a *_construct() function for GstAudioClock
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-01 01:18 UTC by José Alburquerque
Modified: 2008-08-01 17:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Patch to include a *_construc() function for GstAudioClock (2.30 KB, patch)
2008-08-01 01:21 UTC, José Alburquerque
none Details | Review

Description José Alburquerque 2008-08-01 01:18:21 UTC
Would it be possible to include a *_construct() function for GstAudioClock so that after one is created with g_object_new() in the c++ bindings it can be used to initialize it like gst_audio_clock_new() does?  Though we can include the lines that are in gst_audio_clock_new() I'm afraid that things may change in the future and would feel more secure with a *_construct() function that the C API could modify in the future if it does.  A patch follows.
Comment 1 José Alburquerque 2008-08-01 01:21:18 UTC
Created attachment 115650 [details] [review]
Patch to include a *_construc() function for GstAudioClock
Comment 2 Tim-Philipp Müller 2008-08-01 09:38:08 UTC
How about a gst_audio_clock_set_get_time_func() instead? Also, if you're adding something like this you probably want a GDestroyNotify for the user data argument as well, no?

(I'm not really convinced this is useful for bindings at all though. There isn't really any need to wrap it afaics.)
Comment 3 José Alburquerque 2008-08-01 17:24:33 UTC
(In reply to comment #2)
> How about a gst_audio_clock_set_get_time_func() instead? Also, if you're adding
> something like this you probably want a GDestroyNotify for the user data
> argument as well, no?
> 
> (I'm not really convinced this is useful for bindings at all though. There
> isn't really any need to wrap it afaics.)
> 

Nevermind.  For now, I'll include the few lines in gst_audio_clock_new() in the c++ constructor after the g_object_new() gets done in the Glib::Object parent class.  If it's not worth wrapping, it may not be necessary to modify GstAudioClock at all.