After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545739 - Banshee 1.2 not able to "quit"
Banshee 1.2 not able to "quit"
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
1.2.1
Other Linux
: Normal major
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 547047 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-07-31 19:41 UTC by Chris Van Steenlandt
Modified: 2009-02-08 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stdout from "banshee-1 --debug" (13.92 KB, text/plain)
2008-07-31 20:36 UTC, Chris Van Steenlandt
  Details
Stderr from "banshee-1 --debug" (2.21 KB, text/plain)
2008-07-31 20:37 UTC, Chris Van Steenlandt
  Details
Fix the DAAP NRE on exit (576 bytes, patch)
2008-07-31 22:08 UTC, Bertrand Lorentz
committed Details | Review
Output from running banshee with --debug option (8.13 KB, text/plain)
2008-08-31 22:11 UTC, Chris Van Steenlandt
  Details
Banshee log file as demanded (2.18 KB, text/plain)
2008-09-01 20:23 UTC, Chris Van Steenlandt
  Details
Log with banshee hanging (4.29 KB, text/plain)
2008-09-02 19:35 UTC, Chris Van Steenlandt
  Details
Banshee Log During a Hang (3.76 KB, text/plain)
2009-02-08 04:21 UTC, Ray
  Details

Description Chris Van Steenlandt 2008-07-31 19:41:31 UTC
When I select from the menu Media-> quit banshee hangs. I have to close the window and do a "force quit" when prompted.

I'm running Ubuntu 8.04 (Hardy Heron).
Comment 1 Andrew Conkling 2008-07-31 20:01:22 UTC
Can you attach the output of 'banshee-1 --debug'?
Comment 2 Bertrand Lorentz 2008-07-31 20:13:34 UTC
Also, when banshee is hung, run the following command several times and attach
the output you get in the terminal where you started banshee :

kill -QUIT `pidof banshee-1`
Comment 3 Chris Van Steenlandt 2008-07-31 20:36:45 UTC
Created attachment 115638 [details]
Stdout from "banshee-1 --debug"
Comment 4 Chris Van Steenlandt 2008-07-31 20:37:38 UTC
Created attachment 115639 [details]
Stderr from "banshee-1 --debug"
Comment 5 Chris Van Steenlandt 2008-07-31 20:50:14 UTC
Andrew,

I've attached a file from redirected stdout & stderr from the command 'banshee-1 --debug'.

Bertrand,
I executed the command several times (with Banshee started the way described above with the redirection) but was unable to quit Banshee that way. I had to do it via 'close window' and 'Force quit'.

Regards,
Comment 6 Bertrand Lorentz 2008-07-31 21:12:52 UTC
Thanks for the info.

The "kill -QUIT ..." command tell mono to dump a stacktrace of all threads, but it's not always reliable. The output is in the file you attached, but not useful.

I think the DAAP extension may be messing things up. Could disable it and try again to reproduce the bug ?
Comment 7 Chris Van Steenlandt 2008-07-31 21:40:06 UTC
If I disable DAAP, I can indeed quit. But then I can not restart again and I actually fall back into a old bug I already filed : bug 539354 ...
If you want you can close this bug (although DAAP should not mess things up)  but please take a look at 539354.

Thanks
Comment 8 Bertrand Lorentz 2008-07-31 22:08:26 UTC
Created attachment 115644 [details] [review]
Fix the DAAP NRE on exit

This should fix the exception thrown by DAAP on exit, when it couldn't instantiate the browser on startup.

I'm not using DAAP, so that's one of those "blind patches". Please test !
Comment 9 Gabriel Burt 2008-08-08 19:46:01 UTC
Looks good Bertrand, please commit.
Comment 10 Bertrand Lorentz 2008-08-08 19:53:12 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 11 Bertrand Lorentz 2008-08-09 14:44:31 UTC
*** Bug 547047 has been marked as a duplicate of this bug. ***
Comment 12 Chris Van Steenlandt 2008-08-31 22:11:41 UTC
Created attachment 117729 [details]
Output from running banshee with --debug option

The log attached was the result of the following scenario : start up banshee, play a song for 10 seconds, pause it and than quit banshee via menu (Media-> quit). Result is that banshee still hangs and has to be terminated via 'kill pid' statement
Comment 13 Bertrand Lorentz 2008-09-01 09:14:26 UTC
Unfortunately, the debug output doesn't contains anything interesting.

Could you please follow the instructions over there on how to get more information : http://banshee-project.org/contribute/file-bugs/

Specifically, for your case, that would mean doing the following steps :
1. Start banshee from the menu entry
2. Quit banshee. It hangs for you here
3. Open a terminal and run this command: 
kill -s QUIT $(pidof banshee-1); cp ~/.config/banshee-1/log ~/Desktop/banshee.log

4. Attach the banshee.log file that is now on your Desktop

Thanks !
Comment 14 Chris Van Steenlandt 2008-09-01 18:47:18 UTC
Bertrand,

If I follow your instructions, I encounter the following :

1) I do not have a log file in the directory ~/.config/banshee-1. The cp command therefore gives an error
2) The banshee process does not react to the QUIT signal, it keeps on running. It does however recact to a TERM signal.

I'm using the 1.2.1 version available in the ubuntu Hardy Heron repository.

Regards,

Strider
Comment 15 Bertrand Lorentz 2008-09-01 19:24:21 UTC
1) Are you sure you started banshee from the menu entry that was added when you installed it ? ie by clicking on its icon.
If you're starting it from the command line, please run "banshee-1 --redirect-log" so that the output gets written to the log file.

2) As stated in comment #6, the point of the QUIT signal is not to exit banshee, it's to get mono to output a stacktrace of all running threads in the banshee process, so that we can try to figure out where and why it's hanged. 
Comment 16 Chris Van Steenlandt 2008-09-01 20:23:29 UTC
Created attachment 117804 [details]
Banshee log file as demanded

Bertrand,
I started banshee from command prompt with the option you provided (--redirect-log), for some reason my menu entry just starts up banshee with '/usr/bin/banshee-1) (is the redirect log option the default way of starting up banshee ? I did not find that option in the ouput of banshee-1 --help-all ?)

I do not think that the attached file gives a lot of usefull information since the thread dump did not produce much output (see last line of the file)
Comment 17 Bertrand Lorentz 2008-09-02 19:19:01 UTC
Normally, banshee installs a menu entry that starts it with the "--redirect-log" option. It's not in --help-all because it's handled by the startup script.

The log show no threads, so not helpful. Was the banshee window still visible when you executed the "kill ..." command ?
If you manage to get a log file with more info in the thread dump, please attach it here.
Comment 18 Chris Van Steenlandt 2008-09-02 19:35:54 UTC
Created attachment 117871 [details]
Log with banshee hanging

When I quit the application, the window indeed closes but the process keeps on running (which should not be the case). I could however get the window to hang by enabling the DAAP extension (see previous comments) which I disabled and the selecting Media->quit. I then sent a QUIT signal to the banshee process and I now have something in the thread dump. Hope this helps more.
Comment 19 Ray 2009-02-08 04:21:45 UTC
Created attachment 128208 [details]
Banshee Log During a Hang

Ubuntu 8.10 Intrepid Ibex
Banshee 1.2.1
Comment 20 Bertrand Lorentz 2009-02-08 10:33:09 UTC
Strider, Ray,
Could you update to the latest banshee version and try to reproduce the problem ?
Comment 21 Chris Van Steenlandt 2009-02-08 12:34:49 UTC
(In reply to comment #20)
> Strider, Ray,
> Could you update to the latest banshee version and try to reproduce the problem
> ?
> 

Bertrand,

I'm already on Banshee 1.4.2 and this problem disappeared already long time. If Ray could do the same, we can close the issue.

Comment 22 Bertrand Lorentz 2009-02-08 20:48:06 UTC
Closing, as the original issue is fixed.

Ray, if you can reproduce your problem with banshee 1.4.x, please open another bug. Looking at your log, I think it's another issue anyway.