After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545603 - gst-inspect: don't print uri handler when compiled without uri handler support
gst-inspect: don't print uri handler when compiled without uri handler support
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.19
Other All
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-30 22:32 UTC by Robert Schwebel
Modified: 2008-07-31 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.21 KB, patch)
2008-07-30 22:33 UTC, Robert Schwebel
none Details | Review

Description Robert Schwebel 2008-07-30 22:32:23 UTC
Steps to reproduce:
Try to build with --disable-uri.

Stack trace:
gst_inspect_0.10-gst-inspect.o: In function `print_uri_handler_info':
/home/rsc/svn/oselas/bsp/pengutronix/OSELAS.BSP-Pengutronix-AllYes-trunk/platform-phyCORE-PXA270/build-target/gstreamer-0.10.20/tools/gst-inspect.c:730: undefined reference to `gst_uri_handler_get_type

Other information:
Patch follows.
Comment 1 Robert Schwebel 2008-07-30 22:33:12 UTC
Created attachment 115586 [details] [review]
proposed patch
Comment 2 Tim-Philipp Müller 2008-07-31 09:21:25 UTC
While it certainly doesn't hurt to apply this, I think we should just remove this configure option. Not only is it pretty pointless (IMO), but we don't take into account GST_DISABLE_URI *anywhere* in the rest of our code base.
Comment 3 Robert Schwebel 2008-07-31 09:57:20 UTC
For embedded applications, configuring minimal features is definitely a good feature, so I'd suggest to keeps this.

rsc
Comment 4 Sebastian Dröge (slomo) 2008-07-31 15:21:50 UTC
The configure parameters for disabling indexers, uri handlers and enum types are removed now in CVS, making this bug obsolete.

2008-07-31  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        * configure.ac:
        * docs/gst/gstreamer-sections.txt:
        * docs/gst/gstreamer.types:
        * docs/gst/gstreamer.types.in:
        * gst/Makefile.am:
        * gst/gst.c:
        * gst/gstbin.c: (gst_bin_class_init), (gst_bin_set_index_func):
        * gst/gstconfig.h.in:
        * gst/gstelement.c: (gst_element_get_index):
        * gst/gstregistrybinary.c: (gst_registry_binary_save_feature),
        (gst_registry_binary_load_feature),
        (gst_registry_binary_read_cache):
        * gst/gstregistryxml.c: (load_feature),
        (gst_registry_xml_read_cache), (gst_registry_xml_save_feature):
        * plugins/Makefile.am:
        * tools/gst-indent:
        * tools/gst-inspect.c: (print_index_info), (print_element_list),
        (print_plugin_features), (print_element_features):
        * tools/gst-xmlinspect.c: (print_event_masks),
        (print_element_info):
        * win32/common/gstconfig.h:
        Remove GST_DISABLE_(ENUMTYPES|INDEX|URI) everywhere.

        Disabling the indexers and URI handler code will only reduce the
        required amount of memory by a very small amount but on the other hand
        requires much more maintaince work. Apart from that many places of
        code are broken when disabling them.

        Disabling the enum types doesn't reduce the required amount of memory
        by more than a few bytes and makes it hard to fix bugs like #539772,
        i.e. use the enums as GObject properties.


2008-07-31  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        * m4/gst-feature.m4:
        Remove GST_DISABLE_(ENUMTYPES|INDEX|URI).