GNOME Bugzilla – Bug 545597
Mini Video Mode - watch a video while doing something else
Last modified: 2020-03-17 08:26:12 UTC
Please consider addign a Mini Video Mode like in Totem (activated with "H"). In this mini video mode only the a window with the video is displayed to allow setting it Always on Top and watching a video while doing something else.
Created attachment 115585 [details] Mini Video Mode
Maybe this could be something added in the Mini Mode extension.
Can I have this bug assigned to me, please as I am working on getting the compact mode in the NowPlaying extension as discussed on the mailing list.
Created attachment 116796 [details] [review] Patch that implements the mini/compact video mode in NowPlaying As mailed to the mailing list: The following patch series for review adds a compact video playback mode to the NowPlaying extension. This mode is basically a plain window with only the video inside. This allows watching a podcast/show while doing something else at the same time. Such a mode is already present in Totem and I have personally found it very handy. The user visibly changes are a "Compact" toolbar button next to the "Fullscreen" one and an additional "h/H" shortcut key to switch back to normal mode. Please review, thanks.
Patch does not apply. How did you produce it? Also, bug assigned to you; could you not have chosen " Accept bug (confirm bug, and change status to ASSIGNED)"? (Not sure if that shows up for you or not.)
(In reply to comment #5) > Patch does not apply. How did you produce it? > Does not apply because you are applying it wrong. On a fresh checkout: [~/src/svn/banshee]$ patch -p2 < compact-mode-full.patch patching file src/Extensions/Banshee.NowPlaying/Banshee.NowPlaying/FullscreenAdapter.cs patching file src/Extensions/Banshee.NowPlaying/Banshee.NowPlaying/FullscreenWindow.cs patching file src/Extensions/Banshee.NowPlaying/Banshee.NowPlaying/NowPlayingInterface.cs patching file src/Extensions/Banshee.NowPlaying/Resources/ActiveSourceUI.xml > Also, bug assigned to you; could you not have chosen " Accept bug (confirm bug, > and change status to ASSIGNED)"? (Not sure if that shows up for you or not.) > For some reason the "Bug Status Change" part was not visible to me. Either that or I was blind.
Got the patch, didn't realize it was only the first two lines that needed to be trimmed. Thanks for the heads-up. The patch works as designed, but I don't know if it's the best way to go about it: a) I'd think this should be integrated with the Mini Mode extension. b) Once it's in compact mode, it's not entirely discoverable that you need to click the notification area icon or close the video window or press Escape to re-enable normal mode. We'll see what the developers think.
(In reply to comment #7) > The patch works as designed, but I don't know if it's the best way to go about > it: > a) I'd think this should be integrated with the Mini Mode extension. There is no way to currently do that. Check http://mail.gnome.org/archives/banshee-list/2008-August/msg00014.html for the details.
(In reply to comment #8) > There is no way to currently do that. Check > http://mail.gnome.org/archives/banshee-list/2008-August/msg00014.html for the > details. Ah, apologies.
Thanks for the patch Ivan ! A few suggestions for improvement : 1. The "H" shortcut key only allows to go from normal to compact. It should probably work both ways, like "F" does for the fullscreen mode. 2. You could add an entry in the "View" menu, like the one for Fullscreen. 3. A context menu (right click) on the compact window would be nice, in particular to go back to the normal mode. Totem has one.
This doesn't apply anymore - any chance you could update it for trunk again Ivan? I'm very interested in getting this in sooner than later due to nasty implications of some window managers affecting the default now playing video. This is nice to have from an experience point of view but also it's a decent work around to some bugs in other areas of the non-Banshee stack.
Created attachment 121450 [details] [review] Rebased against SVN HEAD I have rebased my patch against SVN HEAD as requested.
Forgot to remove the NEEDINFO flag
Created attachment 121451 [details] [review] Patch rev 3 - svn head + changelog I have revised the patch with a ChangeLog entry.
Hey Ivan, This works fairly well. What's the reasoning behind not showing the controls in compact mode? I think it'd be good to have the controls. Do you think it could be useful to keep the Banshee primary window visible, and let the user hide it themselves it they want? One issue is the sizing of the compact window. The first time I pressed the "Compact" button the resulting window was quite small (208x228 or so) - can we default it to the size of the playing video (and/or remember the size/position by using the PersistentWindowController class)? In my case, the video resolution was 480x480. I agree w/ Bertrand's first two suggestions, and the third would be nice, but it'd be nice for fullscreen too - should be filed as a separate bug/request I think. Thanks!
It's been a while since I've done this patch, but here we go off the top of my head: (In reply to comment #15) > Hey Ivan, > > This works fairly well. What's the reasoning behind not showing the controls > in compact mode? I think it'd be good to have the controls. > Yes, their layout is buggy on smaller sizes. Also no good way to handle "leave compact mode" instead of leave full screen. > Do you think it could be useful to keep the Banshee primary window visible, and > let the user hide it themselves it they want? > > One issue is the sizing of the compact window. The first time I pressed the > "Compact" button the resulting window was quite small (208x228 or so) - can we > default it to the size of the playing video (and/or remember the size/position > by using the PersistentWindowController class)? In my case, the video > resolution was 480x480. > There is no video information exposed right now (such as the resolution) as far as I could tell from the code. From what I saw the PersistentWindowController is very buggy and relies on some magic to work and also relies on some weird timeouts. Also even when I tweaked it a bit the current code doesn't really support the paradigm of compact window and it's position/size saving (in nowplaying). > I agree w/ Bertrand's first two suggestions, and the third would be nice, but > it'd be nice for fullscreen too - should be filed as a separate bug/request I > think. > As for Bertrand's suggestions - they are sound. However: > 1. The "H" shortcut key only allows to go from normal to compact. It should > probably work both ways, like "F" does for the fullscreen mode. I couldn't see a way to define a global shortcut. The fullscreen thing wasn't actually shortcut it was some public eventhandler property exposed in some class that one can replace with a custom one. > 2. You could add an entry in the "View" menu, like the one for Fullscreen. I couldn't see a way to force ordering in the View Menu. Such as how to put the View Compact under View Fullscreen. Based on your feature request ideally the implementation should probably create some sort of an ExternalVideoWindow class with 2 subclasses CompactVideoWindow and FullscreenVideoWindow and the code in nowplaying should get a nice bit of refactoring to make that work. The problem is that I don't have that time available on my hands to work on that right now.
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address. It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.