After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545342 - Can no longer shift+click using Orca
Can no longer shift+click using Orca
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.23.x
Other All
: Normal normal
: 2.24.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-29 16:57 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-03-10 00:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
revision 1 (1.97 KB, patch)
2008-07-29 16:59 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-07-29 16:57:23 UTC
Awhile back we changed Orca to consider all modifiers and their states when determining if a given set of keystrokes was a match for an Orca command or not (see bug # 494196).

By insisting that each keybinding is a specific set of keys -- and only those keys -- we avoid accidentally taking over commands we didn't mean to as well as having ambiguous bindings which might result from the addition of new commands/bindings down the road.

Turns out it breaks Shift+clicking though as reported by Steve on the Orca list.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-07-29 16:59:40 UTC
Created attachment 115508 [details] [review]
revision 1

This patch causes us to "not care" about the presence of other modifiers (and thus restores the ability to shift+click). Functionally tested (both desktop and laptop) and pylinted.  Need to regression test it to be sure, but this should be safe.

Please test.
Comment 2 Joanmarie Diggs (IRC: joanie) 2008-07-30 06:34:35 UTC
We discussed this at today's (okay, technically yesterday's) team meeting. The consensus was to check it into trunk.  Done. Moving to pending.