After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545247 - use g_setenv() insteed of setenv() in sdlvideosink.c
use g_setenv() insteed of setenv() in sdlvideosink.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-29 02:25 UTC by Tal Shalif
Modified: 2008-08-02 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use g_setenv/g_unsetenv (455 bytes, patch)
2008-07-29 02:27 UTC, Tal Shalif 		committed Details | Review

Description Tal Shalif 2008-07-29 02:25:07 UTC 
Please describe the problem:
sdlvideosink.c will not compile under mingw as setenv/unsetenv are not defined in mingw's stdlib.h

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
suggest using Glib's g_setenv() and g_unsetenv() insteed
Comment 1 Tal Shalif 2008-07-29 02:27:08 UTC 
Created attachment 115467 [details] [review]
use g_setenv/g_unsetenv
Comment 2 Sebastian Dröge (slomo) 2008-08-02 17:16:23 UTC 
2008-08-02  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Patch by: Tal Shalif <tshalif at nargila dot org>

        * ext/sdl/sdlvideosink.c: (gst_sdlvideosink_initsdl):
        Use g_setenv() and g_unsetenv() instead of setenv() to fix compilation
        with mingw. Fixes bug #545247.