After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545220 - Infinite loop with server that doesn't support LIST NEWSGROUPS
Infinite loop with server that doesn't support LIST NEWSGROUPS
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other All
: Normal normal
: 0.134
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2008-07-28 20:22 UTC by Per Hedeland
Modified: 2009-09-28 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for the mishandling of response code 503 (936 bytes, patch)
2008-07-28 20:25 UTC, Per Hedeland
none Details | Review

Description Per Hedeland 2008-07-28 20:22:57 UTC
Please describe the problem:
If pan connects to a server that responds with 503 to a LIST NEWSGROUPS command, it will keep disconnecting/reconnecting/retrying forever without getting to the point that any newsgroups are shown.

Steps to reproduce:
1. Configure news.ecomstation.nl as (only) server.


Actual results:
pan keeps looping

Expected results:
pan to become interactive, allowing for the newsgroup list to be shown

Does this happen every time?
yes

Other information:
The 503 response means (per RFC 3977 and existing practice - e.g. INN-2.3.1, 7+ years old) "feature not implemented", but for some reason pan has it as ERROR_TIMEOUT (something that doesn't exist in any version of NNTP, or any other *TP protocol as far as I know), and acts accordingly - which is entirely the wrong thing to do, of course.

Patch is available and will be attached.
Comment 1 Per Hedeland 2008-07-28 20:25:17 UTC
Created attachment 115449 [details] [review]
Patch for the mishandling of response code 503
Comment 2 Per Hedeland 2008-07-28 20:31:54 UTC
See also http://lists.gnu.org/archive/html/pan-users/2008-07/threads.html#00030 - with walt's analysis of the server behavior that triggered the loop, a fix was trivial.
Comment 3 Charles Kerr 2009-09-28 19:44:04 UTC
Fixed in git.gnome.org for 0.134:
http://git.gnome.org/cgit/pan2/commit/?id=f0151ad66bc83f18566a7471c08048c77b0b9cf0