GNOME Bugzilla – Bug 545039
Play Queue would look nice with total queued time summary beside it
Last modified: 2018-05-24 13:30:26 UTC
Greetings Everyone, I've modified the Play Queue GUI to display the total play list time. When there are no tracks queued, the default is displayed as it was previously: Play Queue When there are tracks queued, rather than displaying something like this... Play Queue (8) ...it now displays... Play Queue (8): 39 minutes, 28 seconds
Created attachment 115390 [details] [review] Kip's diff against svn head r5822 I am open to comments and criticisms.
Thanks for moving that patch to bugzilla. There were some issues raised when you posted your patch to the mailing list, does the version you attached here address these issues ?
Thanks Christophe. Yes, I think it addresses them.
I think moch wanted the code in rhythmdb_compute_status_normal and rhythmdb_compute_compact_duration_string to be shared as much as possible, ie one of the 2 functions should call the other, or both should call the same helper function. Your patch doesn't seem to be doing that, does it ?
I thought about that, and the problem is there are some subtle differences in what the status bar wants and what the Play Queue caption wants (as in what can fit). Build after applying my patch to your working copy and you'll see what I mean. There probably will not be as much space in the Play Queue area as in the lengthy status bar. What are your thoughts?
Also try it with the Play Queue both enabled / disabled as the side pane.
The reason why I think the feature is useful, is for when you are DJ'ing or something of that sort. It is nice to know how long you can leave the machine to chat, run to the washroom, grab a drink, or whatever before the Play Queue goes hungry again.
*** Bug 351711 has been marked as a duplicate of this bug. ***
I don't think we can assume that combining the translations for 'n hours', 'm minutes' and 'o seconds' like that will work in all languages. As far as I know, the duration component of rhythmdb_compute_status_normal does this correctly. I don't recall any translators complaining about it, anyway. Another option would be to use rb_make_duration_string, which produces a much more compact form ("1:23:45"). Please try to avoid reformatting code your patch doesn't touch, as it makes your patch harder to read.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/595.