GNOME Bugzilla – Bug 545025
gvfs doesnt use hal storage.icon.drive or storage.icon.volume properties
Last modified: 2009-03-02 12:03:19 UTC
Please describe the problem: The HAL specification (storage namespace section) specifies that the user can over-ride the icons to use for drives and volumes by setting the properties on an object with info.category = storage. This used to work fine in gnome-vfs. However, with gvfs this doesn't work. Looking at the source code, I can see it is using info.desktop.icon to specify the icon. However, this property is not listed at all in the HAL spec. Steps to reproduce: 1. Create an fdi that matches on a disk (e.g. a USB stick), and make it merge the properties storage.icon.drive and storage.icon.volume to specify a user-chosen icon (that needs to be installed at least in the hicolor theme). 2. Insert the disk drive 3. See whether nautilus uses your chosen icon rather than the 'normal' one Actual results: Expected results: Does this happen every time? Other information:
Created attachment 123650 [details] [review] Patch to correct the problem This patch makes the code consistent with the HAL spec (currently version 0.5.10 at http://people.freedesktop.org/~david/hal-spec/hal-spec.html). However, other places have info.desktop.icon (info.desktop.name) which aren't covered by the spec - so it may be that it is better to change the spec!
commited.