After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544855 - fakesrc and fakesink should call super::event()
fakesrc and fakesink should call super::event()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-26 16:21 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2008-08-20 07:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
call super::event() (1.28 KB, patch)
2008-07-26 16:26 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		none Details | Review
call super::event() (1.25 KB, patch)
2008-07-26 17:29 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2008-07-26 16:21:47 UTC 
fakesrc overrides basesrc::event, but does not do any event handling. It should call super::event() to make use of basesrc's implementation. Otherwise seeking, eos and the like don't work.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2008-07-26 16:26:38 UTC 
Created attachment 115322 [details] [review]
call super::event()

fix for both fakesrc and fakesink
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2008-07-26 17:29:41 UTC 
Created attachment 115326 [details] [review]
call super::event()

erm, gstbasesink has no default_event. Call this in a futureproof-save way.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2008-08-20 07:03:31 UTC 
2008-08-20  Stefan Kost  <ensonic@users.sf.net>

	reviewed by: Wim Taymans <wim.taymans@collabora.co.uk>

	* plugins/elements/gstfakesink.c:
	* plugins/elements/gstfakesrc.c:
	  Call super::event() when not handling it. Fixes #544855.