After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544607 - beagle-search applications display broken
beagle-search applications display broken
Status: RESOLVED FIXED
Product: beagle
Classification: Other
Component: General
0.3.8
Other All
: Normal normal
: ---
Assigned To: Beagle Bugs
Beagle Bugs
Depends on:
Blocks:
 
 
Reported: 2008-07-24 21:54 UTC by drago01
Modified: 2008-11-22 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
output of beagle-search -verbose gedit (1.15 KB, text/plain)
2008-07-24 21:58 UTC, drago01
  Details
Same for konqueror (328.80 KB, text/plain)
2008-07-24 21:59 UTC, drago01
  Details
Gedit's desktop file (7.12 KB, text/plain)
2008-07-24 22:00 UTC, drago01
  Details
some screenshots showing the failure (40.00 KB, application/x-tar)
2008-07-24 22:02 UTC, drago01
  Details
beagle-extract-content on gnome-gedit.desktop (565 bytes, text/plain)
2008-07-24 22:56 UTC, drago01
  Details
same for dolphin (kde app) (1.02 KB, text/plain)
2008-07-24 22:58 UTC, drago01
  Details
dolphin's desktop file (2.62 KB, text/plain)
2008-07-24 22:59 UTC, drago01
  Details
Fix for desktopfile filter (1.00 KB, patch)
2008-07-25 17:40 UTC, drago01
none Details | Review

Description drago01 2008-07-24 21:54:39 UTC
Please describe the problem:
For some reason beagle-search just shows an white icon with no text
for applications, in the search results. The bug has been present since 0.2.x and is still here in 0.3.8. For some applications it displays text, for other text and icons for most them it just displays an white icon with no text.
I did some tests and it seems that it only works for KDE applications. Here it either displays icon and text or only text (no icon present?). But for GNOME or non KDE ones it does not work.

Steps to reproduce:
1. start beagle search
2. search for a non KDE app
3. notice the missing text/icon


Actual results:
No text/icon.

Expected results:
It should display the icon and text of the all applications.

Does this happen every time?
Not sure but after the tests I made it seems to always happen for non KDE apps.

Other information:
Comment 1 drago01 2008-07-24 21:58:27 UTC
Created attachment 115204 [details]
output of beagle-search -verbose gedit

This attachment contains the relevant part of the output. Seems like there are no detailed information about the desktop file.
Comment 2 drago01 2008-07-24 21:59:27 UTC
Created attachment 115205 [details]
Same for konqueror

Here the output contains all relevant data and it can display it just fine. (KDE app)
Comment 3 drago01 2008-07-24 22:00:16 UTC
Created attachment 115206 [details]
Gedit's desktop file
Comment 4 drago01 2008-07-24 22:02:53 UTC
Created attachment 115207 [details]
some screenshots showing the failure
Comment 5 Joe Shaw 2008-07-24 22:50:49 UTC
Can you attach the output of beagle-extract-content on gedit.desktop?
Comment 6 drago01 2008-07-24 22:56:21 UTC
Created attachment 115209 [details]
beagle-extract-content on gnome-gedit.desktop

Sure, file is attached. (Seems like there are indeed problems with indexing this file)
Comment 7 drago01 2008-07-24 22:58:54 UTC
Created attachment 115210 [details]
same for dolphin (kde app)

Here with an kde application it works fine.
Comment 8 drago01 2008-07-24 22:59:49 UTC
Created attachment 115211 [details]
dolphin's desktop file
Comment 9 Debajyoti Bera 2008-07-25 16:24:13 UTC
The first line is empty in the gedit.desktop file. I don't think its invalid to have an empty first line but our filter is buggy and it always assumes that the first line is "[Desktop entry]" (or something like that).

BTW, any particular reason the first line is blank ? And I wonder if this is the same in other distributions too since no one else reported anything till now. Possibly they didnt notice.
Comment 10 Joe Shaw 2008-07-25 17:27:49 UTC
(In reply to comment #9)
> The first line is empty in the gedit.desktop file. I don't think its invalid to
> have an empty first line but our filter is buggy and it always assumes that the
> first line is "[Desktop entry]" (or something like that).

Doesn't look like it according to the spec:

http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s02.html

It implies that the .desktop file is like any .ini file and can have multiple "[group]" sections, but that the important one is "[Desktop Entry]"

I think we're requiring a new enough version of glib-sharp these days that we can probably use GKeyFile, which is an API for dealing with ini-like files such as desktop files.
Comment 11 drago01 2008-07-25 17:40:18 UTC
Created attachment 115260 [details] [review]
Fix for desktopfile filter

There is no specific reason why there is an empty first line.
The attached patch fixes this for me it ignores all empty lines before "[Desktop Entry]" .. seems to work fine with all cases I tryed.

Also desktop-file-validate does not complain about the empty line.
Comment 12 Debajyoti Bera 2008-11-22 20:28:09 UTC
I added a slight modification of the patch. r4883 should fix it. Thanks.