After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544433 - Some -good plugins aren't buildable with MSVC
Some -good plugins aren't buildable with MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal blocker
: 0.10.9
Assigned To: Michael Smith
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-23 20:25 UTC by Michael Smith
Modified: 2008-07-23 22:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Build goom with msvc (2.86 KB, patch)
2008-07-23 20:28 UTC, Michael Smith 		accepted-commit_now Details | Review
Fix udpsrc to build with MSVC (570 bytes, patch)
2008-07-23 20:42 UTC, Michael Smith 		none Details | Review
Fix udpsrc on MSVC (version 2) (1.76 KB, patch)
2008-07-23 20:52 UTC, Michael Smith 		accepted-commit_now Details | Review

Description Michael Smith 2008-07-23 20:25:21 UTC 
Patch to be attached.
Comment 1 Michael Smith 2008-07-23 20:28:04 UTC 
Created attachment 115120 [details] [review]
Build goom with msvc

This patch:
 - includes <glib.h> in goom_config.h; this brings in glib's definition of inline (which is needed for msvc)
 - includes config.h so that we get HAVE_INTTYPES_H defines, and we use that as appropriate
 - drops local definition of gint*/guint*, since we're now including glib.h
 - removes an unused definition of MAX (glib defines it for something else)
Comment 2 Michael Smith 2008-07-23 20:42:27 UTC 
Created attachment 115121 [details] [review]
Fix udpsrc to build with MSVC

EAFNOSUPPORT doesn't exist on win32; replace with WSAEAFNOSUPPORT and use WSASetLastError()
Comment 3 Michael Smith 2008-07-23 20:52:28 UTC 
Created attachment 115123 [details] [review]
Fix udpsrc on MSVC (version 2)

There were some more instances of the same problem. This patch fixes them all, and also changes a snprintf() to g_snprintf().
Comment 4 Michael Smith 2008-07-23 22:12:39 UTC 
2008-07-23  Michael Smith <msmith@songbirdnest.com>

    * gst/goom/convolve_fx.c:
    * gst/goom/filters.c:
    * gst/goom/goom_config.h:
    * gst/goom/goom_core.c:
    * gst/goom/goom_tools.h:
      Fix build with MSVC: include glib.h to define inline appropriately,
      use header guards where needed.
    * gst/udp/gstudpnetutils.c:
    * gst/udp/gstudpsrc.c:
      Fix build with MSVC: use WSA* constants/functions where appropriate, use
      g_snprintf rather than snprintf.
      Fixes #544433.