After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544375 - Leaves out PNG files
Leaves out PNG files
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnome-sudoku
2.22.x
Other Linux
: Normal normal
: ---
Assigned To: Thomas M. Hinkle
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-23 15:52 UTC by Josselin Mouette
Modified: 2008-08-07 18:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not use temporary files (964 bytes, patch)
2008-07-23 15:55 UTC, Josselin Mouette
committed Details | Review

Description Josselin Mouette 2008-07-23 15:52:49 UTC
Currently, the thumbnail rendering code uses temporary files. Not only this is completely useless, but it forgets to remove them, leaving PNG files in /tmp.
Comment 1 Josselin Mouette 2008-07-23 15:55:05 UTC
Created attachment 115098 [details] [review]
Do not use temporary files

This simple patch removes the need for temporary files.

It would probably be better to do the rendering directly with cairo, but it requires changes to the ListStore and all the code that uses it.
Comment 2 Thomas Andersen 2008-08-07 18:00:36 UTC
Committed on trunk in rev 7810. The fix will be in the 2.23.90 release. Thanks Josselin!