GNOME Bugzilla – Bug 544277
Build fail because gnome-keyring.h not found
Last modified: 2008-07-23 17:47:58 UTC
I'm building vino trunk r876 on Solaris, I get following error: /ws/onnv-tools-prc/SUNWspro/SS11/bin/cc -DHAVE_CONFIG_H -I. -I.. -DVINO_LOCALEDIR=\""/usr/share/locale"\" -DORBIT2=1 -D_REENTRANT -D_PTHREADS -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -g -c vino-passwd.c "vino-passwd.c", line 41: cannot find include file: <gnome-keyring.h> "vino-passwd.c", line 52: undefined symbol: GnomeKeyringResult "vino-passwd.c", line 52: syntax error before or at: result "vino-passwd.c", line 55: undefined symbol: result "vino-passwd.c", line 55: warning: implicit function declaration: gnome_keyring_set_network_password_sync "vino-passwd.c", line 67: undefined symbol: GNOME_KEYRING_RESULT_OK "vino-passwd.c", line 71: cannot recover from previous errors cc: acomp failed for vino-passwd.c $pkg-config --cflags gnome-keyring-1 -I/usr/include/gnome-keyring-1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
When I fix the upper error with following patch, I got another error: /ws/onnv-tools-prc/SUNWspro/SS11/bin/cc -g -o vino-passwd vino-passwd.o -lgconf-2 -lgnome-keyring -lglib-2.0 -ljpeg -lz Undefined first referenced symbol in file g_object_unref vino-passwd.o (symbol belongs to implicit dependency /usr/lib/libgobject-2.0.so.0) ld: fatal: Symbol referencing errors. No output written to vino-passwd Index: trunk/tools/Makefile.am =================================================================== --- trunk/tools/Makefile.am (revision 876) +++ trunk/tools/Makefile.am (working copy) @@ -3,6 +3,7 @@ INCLUDES = \ -DVINO_LOCALEDIR=\""$(prefix)/$(DATADIRNAME)/locale"\" \ $(VINO_TOOLS_CFLAGS) \ + $(VINO_KEYRING_CFLAGS) \ $(WARN_CFLAGS) \ $(NULL) @@ -14,5 +15,6 @@ vino_passwd_LDADD = \ $(VINO_TOOLS_LIBS) \ + $(VINO_KEYRING_LIBS) \ $(NULL) I'll make a combined patch to fix these two build error altogether.
Created attachment 115076 [details] [review] patch for bug #544277 Please review this patch, if it is okay, can I commit?
Hi, Halton. Sure you can commit it. Thanks!
Created attachment 115089 [details] [review] Another patch to fix the build Isn't a better idea fix the issue in VINO_TOOLS_LIBS definition in configure.in?
(In reply to comment #4) > Created an attachment (id=115089) [edit] > Another patch to fix the build > > Isn't a better idea fix the issue in VINO_TOOLS_LIBS definition in > configure.in? > Luca, To fix the gobject issue, your patch should looks like: Index: configure.in =================================================================== --- configure.in (revisione 876) +++ configure.in (copia locale) @@ -47,7 +47,7 @@ PKG_CHECK_MODULES(VINO_CAPPLET, glib-2.0 >= 2.12.0 gtk+-2.0 >= 2.10.0 gconf-2.0 libglade-2.0 libgnomeui-2.0 dbus-glib-1) -PKG_CHECK_MODULES(VINO_TOOLS, glib-2.0 >= 2.12.0 gconf-2.0) +PKG_CHECK_MODULES(VINO_TOOLS, glib-2.0 >= 2.12.0 gconf-2.0 gobject-2.0 >= 2.12.0 gnome-keyring-1) dnl --enable-libnotify=(yes|no|auto) LIBNOTIFY_VERSION=0.4.4 Either way is okay for me. I'll hold this patch now until we make a choice.
I'd prefer the last one, Luca+gobject by Halton. Feel free to commit.
Patch committed.