After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544174 - [basesrc] allow dynamic value of the seekable value.
[basesrc] allow dynamic value of the seekable value.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-22 14:39 UTC by Thijs Vermeir
Modified: 2008-07-28 22:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basesrc_seekable.diff (2.50 KB, patch)
2008-07-22 14:39 UTC, Thijs Vermeir
none Details | Review

Description Thijs Vermeir 2008-07-22 14:39:12 UTC
Now in basesrc the is_seekable function from the baseclass is only called once at start. So this means that baseclass can choose only at startup that it would be seekable or not.

If you want to create an element that can enable/disable seeking, like a dvd src that isn't seekable in the menu's but is seekable in the movie, it is not possible to inform the baseclass about it with the current implementation.

This patch ask on every query on the baseclass if it is seekable. So, it is now possible for the baseclass to disable/enable seeking.
Comment 1 Thijs Vermeir 2008-07-22 14:39:41 UTC
Created attachment 115007 [details] [review]
basesrc_seekable.diff
Comment 2 Thijs Vermeir 2008-07-24 14:49:20 UTC
Committed:
       * libs/gst/base/gstbasesrc.c:
       * libs/gst/base/gstbasesrc.h:
       Don't cache the seekable status.
       Fixes bug #544174