After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544029 - empathy's configure.ac doesn't detect python 2.6
empathy's configure.ac doesn't detect python 2.6
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2008-07-21 16:49 UTC by Santiago M. Mola
Modified: 2008-10-06 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
detect python 2.6 (511 bytes, patch)
2008-08-08 13:12 UTC, Frederic Peters 		rejected Details | Review
use AM_PATH_PYTHON to be more generic (441 bytes, patch)
2008-08-08 13:42 UTC, Laurent Bigonville 		reviewed Details | Review
use AM_PATH_PYTHON, so Python 2.6 is also detected (1.79 KB, patch)
2008-10-05 16:24 UTC, Frederic Peters 		committed Details | Review

Description Santiago M. Mola 2008-07-21 16:49:08 UTC 
Please describe the problem:
configure.ac only looks for python 2.3, 2.4, 2.5. Considering that Python 2.6 is coming soon it'd be good to have this fixed on next empathy release.

--- empathy-0.23.4/configure.ac	2008-07-15 13:59:12.000000000 +0200
+++ empathy-0.23.4.new/configure.ac	2008-07-21 14:26:12.000000000 +0200
@@ -69,7 +69,7 @@
 if test -z "$XSLTPROC"; then
   AC_MSG_ERROR([xsltproc (from libxslt) is required])
 fi
-AC_CHECK_PROGS([PYTHON], [python python2.3 python2.4 python2.5])
+AC_CHECK_PROGS([PYTHON], [python python2.3 python2.4 python2.5, python2.6])
 if test -z "$PYTHON"; then
   AC_MSG_ERROR([Python is required])
 fi


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Frederic Peters 2008-08-08 13:12:34 UTC 
Created attachment 116140 [details] [review]
detect python 2.6

Attached as patch (and fixed to remove the comma).
Comment 2 Laurent Bigonville 2008-08-08 13:42:58 UTC 
Created attachment 116145 [details] [review]
use AM_PATH_PYTHON to be more generic
Comment 3 Xavier Claessens 2008-08-08 13:48:44 UTC 
Note that AM_PATH_PYTHON is already used for the python binding, maybe you can remove that call there?
Comment 4 Frederic Peters 2008-10-05 16:24:41 UTC 
Created attachment 119967 [details] [review]
use AM_PATH_PYTHON, so Python 2.6 is also detected

This patch removes the AM_PATH_PYTHON check when building Python extensions as it is no longer necessary.
Comment 5 Xavier Claessens 2008-10-05 20:19:21 UTC 
Why do you remove the error message if python is not found? Or does AM_PATH_PYTHON handle errors for us?
Comment 6 Frederic Peters 2008-10-05 20:29:11 UTC 
It does.

(...)
checking for a Python interpreter with version >= 2.3... none
configure: error: no suitable Python interpreter found
Comment 7 Xavier Claessens 2008-10-06 07:57:44 UTC 
Great, thanks! You can commit. I guess it's fine for the 2.24 branch too.
Comment 8 Frederic Peters 2008-10-06 09:15:03 UTC 
Thanks; commited in both places.