GNOME Bugzilla – Bug 543875
Use libcanberra to play a test sound when changing the volume
Last modified: 2013-01-04 21:03:40 UTC
Patch attached
Created attachment 114862 [details] [review] 20080720_bgo_543875_canberra+mixer.diff Proposed patch
Three things: - I think you want to use audio-xxxx instead of complete-media-burn here. - It would make sense to use ca_gtk_play_for_event() instead of ca_gtk_play_for_widget() here - It would be cool to set CA_PROP_EVENT_DESCRIPTION for all sound events, to help a11y people.
Created attachment 114864 [details] [review] 20080720_bgo_543875_canberra+mixer.diff: v2 Updated following Lennart's comments. Note that audio-volume-change is not present in the freedesktop theme, you'll have to copy something there to test this.
Looks good to me! Thank you!
I haven't looked at the patch in great details yet. I just want to be sure that the event is only triggered when the mouse is released though.
Yes, that was my first problem. But now you made me wonder if it works with keyboard...
Well it doesn't work with keyboard. It got tricky now...
Created attachment 114981 [details] [review] bgo_543875_canberra+mixer.diff Updated, this works with keyboard!. It produces the sound only when click is released and keyboard button is pressed. Works fine. Please test.
Ping?
I'm currently doing some serious renovation on the mixer applet that should occur before this goes in. Including the test sound is part of the plan for this work. Merging in your patch should be trivial despite the changes.
Bastien I think you committed something like this for the volume applet in 2.28, at least on Fedora I recall a test sound when changing the volume, although perhaps that's a Fedora only patch.
/me doesn't care much anymore, as the volume "applet" is now the notification area icon provided by gnome-media.
AH! right, I forgot this was once an applet. There's indeed a sound in the tray icon. /me doesn't care anymore