After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543860 - [modplug] Uses CFLAGS for CXXFLAGS
[modplug] Uses CFLAGS for CXXFLAGS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-20 14:12 UTC by Sebastian Dröge (slomo)
Modified: 2008-07-21 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
modplug-cxxflags.patch (679 bytes, patch)
2008-07-20 14:12 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2008-07-20 14:12:08 UTC 
Hi,
the modplug plugin currently uses GST_CFLAGS for CXXFLAGS. As this can include warning parameters, etc which are not valid for C++ this is wrong. GST_CXXFLAGS should be used instead.

-Wdeclarations-after-statements for example is not valid for C++

Attached patch fixes this.
Comment 1 Sebastian Dröge (slomo) 2008-07-20 14:12:54 UTC 
Created attachment 114851 [details] [review]
modplug-cxxflags.patch

Btw, with the Sun C++ compiler this will even fail to build because of some parameter
Comment 2 Jan Schmidt 2008-07-20 21:11:12 UTC 
please commit
Comment 3 Sebastian Dröge (slomo) 2008-07-21 10:16:40 UTC 
2008-07-21  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        * gst/modplug/libmodplug/Makefile.am:
        Use GST_CXXFLAGS instead of GST_CFLAGS for CXXFLAGS. GST_CFLAGS
        can contain compiler parameters that are invalid for C++.
        Fixes bug #543860.