After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543404 - [taginject] needs fixing and API review
[taginject] needs fixing and API review
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.9
Other Linux
: Normal blocker
: 0.10.8
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-17 09:31 UTC by Tim-Philipp Müller
Modified: 2008-07-26 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
move sending tags to transform_ip (3.00 KB, patch)
2008-07-21 19:33 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Tim-Philipp Müller 2008-07-17 09:31:14 UTC 
The recently-added taginject element in gst/debug/ needs both API review and some fixing (e.g. sending tags in the ::start method is simply wrong).
Comment 1 Jan Schmidt 2008-07-18 18:03:08 UTC 
Should I cut the first pre-release anyway?
Comment 2 Edward Hervey 2008-07-18 18:14:41 UTC 
how did this land into -good without any *prior* review ? I would de-activate that code and do the pre-release.
Comment 3 Tim-Philipp Müller 2008-07-18 18:37:08 UTC 
> Should I cut the first pre-release anyway?

Don't see why not, but maybe add a word of warning somewhere for good measure. It's unlikely that I'll come up with a patch before the prerelease.
Comment 4 Jan Schmidt 2008-07-18 23:27:40 UTC 
(In reply to comment #2)
> how did this land into -good without any *prior* review ? I would de-activate
> that code and do the pre-release.
> 

Haw haw - says the guy who wants to land hdv1394src after the freeze ends ;)
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2008-07-21 19:33:03 UTC 
Created attachment 114941 [details] [review]
move sending tags to transform_ip

Tested with those two use-cases (wavenc does not write tags :/)
gst-launch audiotestsrc num-buffers=100 ! taginject tags="title=testsrc,artist=gstreamer" ! lame ! avimux ! filesink location=taginject.avi

gst-launch audiotestsrc num-buffers=100 ! taginject tags="title=testsrc,artist=gstreamer" ! vorbisenc ! oggmux ! filesink location=taginject.ogg
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2008-07-22 06:32:38 UTC 
2008-07-22  Stefan Kost  <ensonic@users.sf.net>

	* gst/debug/gsttaginject.c:
	* gst/debug/gsttaginject.h:
	  Sent tags in _transform_ip() instead of _start(). Fixes #543404
	  partially.

Anything else or can this be closed?
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2008-07-26 12:02:47 UTC 
__tim confirmed on irc that its okay now.