After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543286 - deinterlace2 doesn't build outside gcc
deinterlace2 doesn't build outside gcc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other opensolaris
: Normal blocker
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-16 14:01 UTC by Jan Schmidt
Modified: 2008-07-18 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix forte build (7.07 KB, patch)
2008-07-16 14:01 UTC, Jan Schmidt
none Details | Review
fix forte build (6.54 KB, patch)
2008-07-16 14:05 UTC, Jan Schmidt
rejected Details | Review

Description Jan Schmidt 2008-07-16 14:01:04 UTC
Patch attached to fix the deinterlace2 build with Forte, which probably fixes it for other non-gcc compilers too.
Comment 1 Jan Schmidt 2008-07-16 14:01:30 UTC
Created attachment 114665 [details] [review]
fix forte build
Comment 2 Jan Schmidt 2008-07-16 14:05:39 UTC
Created attachment 114667 [details] [review]
fix forte build

remove a little whitespace noise in the first patch.
Comment 3 Sebastian Dröge (slomo) 2008-07-18 08:33:51 UTC
Ok, I've fixed this a bit different now. tomsmocomp is now disabled for this release until I've ported it and the bugs are fixed.

Also the plugin is now built on all architectures but the inline assembly is only built if we build on x86 or amd64 and gcc inline assembly is supported.
Can you confirm that this works on forte too this way?

2008-07-18  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

	* configure.ac:
	* gst/deinterlace2/Makefile.am:
	* gst/deinterlace2/gstdeinterlace2.c:
	(gst_deinterlace2_methods_get_type), (gst_deinterlace2_set_method),
	(gst_deinterlace2_class_init), (gst_deinterlace2_init):
	* gst/deinterlace2/gstdeinterlace2.h:
	* gst/deinterlace2/tvtime/greedy.c:
	(gst_deinterlace_method_greedy_l_class_init):
	* gst/deinterlace2/tvtime/greedyh.c:
	(gst_deinterlace_method_greedy_h_class_init):
	* gst/deinterlace2/tvtime/vfir.c:
	(gst_deinterlace_method_vfir_class_init):
	Disable the tomsmocomp algorithm for this release as it's buggy
	and has no C implementation yet.

	Build the deinterlace2 plugin on all architectures but still mark it
	as experimental.
	
	Build the x86 inline assembly only if GCC inline assembly is supported
	and only on x86 or amd64. Fixes bug #543286.