After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543255 - -Wno-attributes does not exist in every gcc version
-Wno-attributes does not exist in every gcc version
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-16 10:26 UTC by Benoit Fouet
Modified: 2008-07-17 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove -Wno-attributes (581 bytes, patch)
2008-07-16 10:26 UTC, Benoit Fouet 		rejected Details | Review
Use -Wno-attributes only if the c++ compiler supports it (1.33 KB, patch)
2008-07-16 14:02 UTC, Tim-Philipp Müller 		committed Details | Review

Description Benoit Fouet 2008-07-16 10:26:06 UTC 
ext/taglib Makefile uses -Wno-attributes compiler option, which is not handled in every gcc version.
Comment 1 Benoit Fouet 2008-07-16 10:26:44 UTC 
Created attachment 114654 [details] [review]
remove -Wno-attributes
Comment 2 Tim-Philipp Müller 2008-07-16 14:01:00 UTC 
Just removing --Wno-attributes isn't really the ideal solution, since it may break the CVS build with -Werror.
Comment 3 Tim-Philipp Müller 2008-07-16 14:02:01 UTC 
Created attachment 114666 [details] [review]
Use -Wno-attributes only if the c++ compiler supports it
Comment 4 Tim-Philipp Müller 2008-07-17 14:41:46 UTC 
2008-07-17  Tim-Philipp Müller  <tim.muller at collabora co uk>

	* configure.ac::
	* ext/taglib/Makefile.am::
	  Only use -Wno-attributes (which is there to work around a
	  bug in the taglib 1.5 headers) if the c++ compiler actually
	  supports it (#543255).