After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543058 - IMAP INBOX renaming
IMAP INBOX renaming
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-07-15 08:55 UTC by Paul Bolle
Modified: 2008-08-04 06:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix bug 543058 (1.57 KB, patch)
2008-07-15 08:59 UTC, Paul Bolle
committed Details | Review

Description Paul Bolle 2008-07-15 08:55:24 UTC
In the current GUI an IMAP "INBOX" will be displayed as "Inbox" in the folder list in the side bar.

However it is displayed as "INBOX" in:
- the (bold) label of the side bar;
- the folder properties dialog;
- the window title (as displayed by the windowmanager).

I suggest to replace these three occurrences of INBOX in the GUI code with Inbox too. INBOX is a written in all caps because that is the way it is used in the IMAP protocol. There's little reason to use it in the GUI. Inbox is properly capitalized and can be localized too.

I'll attach a patch shortly.

(Note that even without my patch the INBOX is also displayed as "Inbox" in the IMAP Folder Subscriptions dialog. I assume this is done by the current "INBOX" renaming code, which I assume is found in em_folder_tree_get_selected_folder_info() in mail/em-folder-tree.c. One might argue that in that dialog INBOX is actually more appropriate, as subscribing to IMAP folders seems to me to be something where using more exact terminology is probably better.)
Comment 1 Paul Bolle 2008-07-15 08:59:13 UTC
Created attachment 114583 [details] [review]
patch to fix bug 543058

Patch against current trunk. Tested on 2.22. (The patch differs form the patch I tested on 2.22, as the code changed, but it should behave identical.)
Comment 2 Srinivasa Ragavan 2008-07-27 18:41:32 UTC
I think it is fine to do so.
Comment 3 Suman Manjunath 2008-08-04 03:59:35 UTC
Patch committed to SVN trunk as r35899
http://svn.gnome.org/viewvc/evolution?view=revision&revision=35899

String change to be announced to gnome-doc-list and gnome-i18n before closing the bug. 
Comment 4 Suman Manjunath 2008-08-04 06:35:10 UTC
Announced. 
http://mail.gnome.org/archives/gnome-doc-list/2008-August/msg00009.html