GNOME Bugzilla – Bug 542693
Use sounds for events, with libcanberra
Last modified: 2008-07-28 10:14:15 UTC
The feeling at guadec was positive for libcanberra and the sound usage across the desktop, hence here's the bug for epiphany. So far I could think of: - download complete Sorry, I'm short in creativity right now.
Maybe a warning sound when an error page s shown?
Checking http://0pointer.de/public/sound-naming-spec.html I couldn't find any other sensible thing that would have to be implemented directly in Epiphany. I don't recall if we get an alert window when a download is cut in the middle (by network error or whatever). If not, we could have another notification with an error sound, the error dialog should be catched by the gtk+ plugin of canberra I think.
Created attachment 114778 [details] [review] 20080718_bgo_542693_epiphany-canberra.diff Adds the download finished sound, since there's no download-complete sound in the test sound theme, i used phone-incoming-call. Obviously we'll be using download-complete, this is left like that just for the sake of actually hearing something.
Note: this is missing CA_PROP_EVENT_DESCRIPTION and /not sure/ if i18n in the other string props.
The event id is phone-incoming-call. That doesn't look right to me...
The event is called "complete-download". See http://0pointer.de/public/sound-naming-spec.html
Created attachment 114978 [details] [review] [PATCH] Libcanberra for sounds Enable the download-complete sound for the downloader. --- configure.ac | 8 ++++++++ embed/downloader-view.c | 10 ++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-)
Oh wow, awesomeness. git-send-bugzilla.
Marking the old patch obsolete.
Done.
I wonder if this was the proper way to do it. libnotify support "sound hint", it could have been a patch of notify-daemon instead, and that would have work for any notifier. I am not sure if "sound hint" is meant for "sound names", but that would not be difficult to convince them to us that. To be even more flexible, the sound daemon should support customization of actions (matching of events => popup, sound, blink). But let's not make it too complicated for nothing, of course.
Actually, I think libcanberra should talk to the notification-daemon when important actions finish, to get a visual cue about a problem.
(In reply to comment #12) > Actually, I think libcanberra should talk to the notification-daemon when > important actions finish, to get a visual cue about a problem. > I am not fond of this idea.. if instead, the preferred path for notifications would be libnotify, it would get an error "_from_ libcanberra returns, and then choose to display a bubble. of course everything is possible and I hate chicken-egg problems
It looks to me libcanberra-gtk is a required dependency with this patch. Then why the #ifdef HAVE_LIBCANBERRA_GTK in the code?
Fixed the optional'ness of this. Thanks.