Created attachment 114500 [details] [review]
parse asm instruction list in GDB/MI format

This patch just adds support for parsing asm instructions as returned by GDB in MI format. The patch also adds a unit test for that.

There is no IDebugger API designed to query for the disassembled code from GDB yet. That will be the next step.

Created attachment 116248 [details] [review]
basic support of disassembling to IDebugger

This patch adds support to disassembling to IDebugger and provides a first implementation. A basic diassembling UI can now be attempted on top of this API.

A (regression) test program is provided.

Comment on attachment 116248 [details] [review]
basic support of disassembling to IDebugger

I forgot to say that the patch does not provide any GUI for disassembling yet. That should be the next step.

It's quite hard to review this since there's so many formatting changes in there as well.  There's a lot of changes to the functions dealing with reading registers.  I can't tell if there's any actual changes or if it's all formatting changes.  But from what I can tell, the new API looks ok.

Created attachment 143533 [details]
Updated patch against master

This patch refreshes the previous one and cleans it up to remove all the cruft not directly related to disassembling. It should be easier to read and review. Pfeww, one year later. Looks like kids are growing.

Created attachment 143545 [details] [review]
Patch update

Another update of the patch against latest master.

This is now work in progress. See my last report on the mailing list at http://mail.gnome.org/archives/nemiver-list/2010-April/msg00000.html

Support for this feature has just been merged into master.