GNOME Bugzilla – Bug 542329
gtk_tree_view_column_cell_get_size() parameters need more documentation
Last modified: 2018-05-02 14:33:53 UTC
The cell_area parameter of gtk_tree_view_column_cell_get_size() has become const in GTK+ 2.13. It's good that it's now clearer that it's not an ouput variable, but this has made it more obvious that I don't understand what that parameter is used for, and what it means when it is NULL. http://library.gnome.org/devel/gtk/unstable/GtkTreeViewColumn.html#gtk-tree-view-column-cell-get-size
Marking with the 2.14 API Freeze Target Milestone, because I would like to have the documentation for this so we can create the correct API for gtkmm.
Hello Murray, Are the current docs enough for you?
Well, no, not re(In reply to comment #2) > Hello Murray, > > Are the current docs enough for you? Well, no, not really. Has it even changed? It just says "The area a cell in the column will be allocated" which makes it sound like an output variable, though it can't be because it's now const. One way to make mysterious parameters less mysterious is to suggest from where the parameter's value might be obtained. Also, I guess there should be some explanation of how that area is different from the x,y,width,height parameters.
Also, are can be NULL, but there's not explanation of what that would mean. I wonder if it really is meant to be an output parameter after all.
The cell_area parameter is now completely unused for that function. That function will reliably return the minimum size needed to render a column for a single row, however it will return the minimum-height-for-minimum-width. Probably this function should be headed towards an early deprecation in 3.0. I'm also not entirely sure what use that function has outside of GTK+ (if it indeed has any use).
The cell_area parameter is not used by gtk_tree_view_column_cell_get_size(). The calls that I find in gtk+ have cell_area == NULL. Isn't it a good idea to remove that parameter in gtk+-4 before ABI/API is frozen?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/297.