After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 541962 - [directdrawsink] crash when exposing in GST_STATE_READY
[directdrawsink] crash when exposing in GST_STATE_READY
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-07 21:48 UTC by Julien Isorce
Modified: 2009-08-09 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.04 KB, patch)
2008-07-07 21:53 UTC, Julien Isorce 		committed Details | Review

Description Julien Isorce 2008-07-07 21:48:04 UTC 
Hi,

Steps to Reproduce:

Go to GST_STATE_READY.
Then resize or obscur the window.


Actual Results:
Crash into gst_directdraw_sink_show_frame due to a zero division.
(because when going to GST_STATE_READY the height is set to 0)


J.
Comment 1 Julien Isorce 2008-07-07 21:53:00 UTC 
Created attachment 114151 [details] [review]
patch

A very small patch to avoid the crash.
But I am not sure if it's the best way. 
So do not hesitate to fix the bug in otherway.

J.
Comment 2 Tim-Philipp Müller 2009-08-09 00:47:01 UTC 
directdrawsink is in -bad now.

Julien: any reason not to commit this?
Comment 3 Sebastian Dröge (slomo) 2009-08-09 10:26:25 UTC 
The patch looks very correct to me so I've committed it now to get it into the next -bad release.


commit 182dad5c6694cd4bee1fa030d9b968687e21d522
Author: Julien Isorce <julien.isorce@gmail.com>
Date:   Sun Aug 9 12:25:01 2009 +0200

    directdrawsink: Fix crash when exposing in GST_STATE_READY
    
    Fixes bug #541962.