GNOME Bugzilla – Bug 541828
Karma DAP support is not in 1.0
Last modified: 2008-08-15 21:05:24 UTC
Please describe the problem: Karma plugin was not yet forward ported to 1.0. Patch to follow. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 114094 [details] [review] Add support for Rio Karma back to banshee The patch ports the Rio Karma DAP back to the 1.0 codebase
Patch works. Except shouldn't this line: --- banshee.orig/configure.ac 2008-07-04 12:38:53.000000000 -0400 ...be changed to banshee/configure.ac? Okay, that's a minor one =) I have some other minor details: 1) My player shows up twice. First player cannot load and is continuously showing a loading message. Debug output says: * Libkarma warning: no device-settings file Second player shows up just fine. Quite breathtaking to have such a beautiful interface. 2) Plugging in the Karma while Banshee is already running makes it freeze. No debug output =( I have tested this, and it's reproducible every time. Killing Banshee and restarting it works. 3) Mounting the Karma while Banshee is running only makes the "defunct" player from 1) show up. Please ask for more details if necessary.. and once again nice going, Bob! I'm thinking about making a Ubuntu n00b how-to on the process of compiling and inserting the patch. / Benjamin
(In reply to comment #2) > Patch works. Except shouldn't this line: > > --- banshee.orig/configure.ac 2008-07-04 12:38:53.000000000 -0400 > > ...be changed to banshee/configure.ac? Okay, that's a minor one =) I have some > other minor details: I don't think it matters. I used quilt to generate the patch and I think the patch utility only cares about the target name. Did you have any problem applying it? > 1) My player shows up twice. First player cannot load and is continuously > showing a loading message. Debug output says: > > * Libkarma warning: no device-settings file > > Second player shows up just fine. Quite breathtaking to have such a beautiful > interface. Can you disable the Mass Storage plugin through the banshee menus and see if you still get two icons? Hopefully the working one is the karma plugin :) > 2) Plugging in the Karma while Banshee is already running makes it freeze. No > debug output =( I have tested this, and it's reproducible every time. Killing > Banshee and restarting it works. > > 3) Mounting the Karma while Banshee is running only makes the "defunct" player > from 1) show up. Yeah I'm not sure the device detection works properly. The way I have it now, it looks for the Karma but it probably should only look at the mounted file systems since there will be some lag between plug-in and something mounting the file system. > Please ask for more details if necessary.. and once again nice going, Bob! I'm > thinking about making a Ubuntu n00b how-to on the process of compiling and > inserting the patch. > > / Benjamin >
(In reply to comment #3) > I don't think it matters. I used quilt to generate the patch and I think the > patch utility only cares about the target name. Did you have any problem > applying it? No, probably only if you're in the parent dir and using patch -p0... not sure. Okay whatever =) > > 1) My player shows up twice. First player cannot load and is continuously > > showing a loading message. Debug output says: > > > > * Libkarma warning: no device-settings file > > > > Second player shows up just fine. Quite breathtaking to have such a beautiful > > interface. > > Can you disable the Mass Storage plugin through the banshee menus and see if > you still get two icons? Hopefully the working one is the karma plugin :) Bingo! We could ask the Mass Storage guys to add Karma to a blacklist, but I'm fine with simply disabling it for now. > Yeah I'm not sure the device detection works properly. The way I have it now, > it looks for the Karma but it probably should only look at the mounted file > systems since there will be some lag between plug-in and something mounting the > file system. Maybe a little sleep() will do here, but it sounds like a good explanation. I didn't see this behavior in the old Banshee, though. But once again: Good job! I've never used an interface for my Karma before that was this cool.
This looks fine to me, but let's wait until after the current string freeze (that is, until 1.2.1) to commit.
Sounds good, thanks
Committed, thanks Bob !