After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 541782 - Implement woohoo bar in Epiphany
Implement woohoo bar in Epiphany
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: [obsolete] URL bar
unspecified
Other All
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on: 562701
Blocks: 350853 516550
 
 
Reported: 2008-07-06 16:26 UTC by John Richard Moser
Modified: 2009-01-19 23:18 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
woohoo bar for ephy (126.54 KB, image/png)
2008-08-13 23:24 UTC, Diego Escalante Urrelo (not reading bugmail)
  Details
[PATCH] Implement the woohoo bar. (5.84 KB, patch)
2008-08-14 23:52 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
Sizing bug (21.23 KB, image/png)
2008-08-14 23:55 UTC, Diego Escalante Urrelo (not reading bugmail)
  Details
[PATCH] Implement woohoo bar in epiphany (5.83 KB, patch)
2009-01-13 23:21 UTC, Diego Escalante Urrelo (not reading bugmail)
committed Details | Review

Description John Richard Moser 2008-07-06 16:26:51 UTC
I believe the new address bar (the "Awesome Bar") in Firefox 3 represents a significant usability enhancement and would benefit Epiphany greatly.  The Awesome Bar functions as the Address Bar, but makes suggestions from several sources including:

* URLs in history
* URLs in bookmarks
* Page titles in history
* Names of bookmarks

This feature makes recalling previously visited or bookmarked pages much easier, as the user can associate content with minor context (usually page title, which represents the topic) rather than just the URL, and does not have to look through all bookmarks trying to remember which was what.

Other information:
The implementation in Firefox 3 also places a yellow star next to any bookmarked page (right-aligned on the location bar) both as part of the location bar and when suggesting results.  This is not critical, but does help differentiate between "pages I've seen" and "pages I've bookmarked," adding one more piece of familiar information to the lookup.
Comment 1 Reinout van Schouwen 2008-07-10 11:10:08 UTC
(In reply to comment #0)
 
> * URLs in history
> * URLs in bookmarks

> * Names of bookmarks

As far as I know, Epiphany's address entry already searches in all of these AND topic names. Page titles would be a nice addition. The yellow star indicator is bug 350853.

Is there something else I've forgotten?
Comment 2 Bruce Cowan 2008-08-13 23:15:38 UTC
The patch on bug 517960 would help a lot.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2008-08-13 23:24:48 UTC
Created attachment 116537 [details]
woohoo bar for ephy

just an experiment i did this week, it has some backend issue though.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2008-08-14 23:51:07 UTC
Retitling, attaching patches for woohoo bar here after a not so quick rebase.

Oh and one more thing, it has a bug when the first time you open the completion, it's wrong sized. Screenshot follows.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2008-08-14 23:52:10 UTC
Created attachment 116624 [details] [review]
[PATCH] Implement the woohoo bar.


This removes the extracell from the completion popup, it's now only one column
wide with a woohoo look.
It deprecates the bolding branch, but for now they must run parallel until we
decide if we want this or not. Also this must be sporting the blank completion
bug.
---
 lib/widgets/ephy-location-entry.c |  109 +++++++++++++++++++++++++------------
 src/ephy-completion-model.c       |   16 ++----
 2 files changed, 80 insertions(+), 45 deletions(-)
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2008-08-14 23:55:12 UTC
Created attachment 116625 [details]
Sizing bug

Appears when opening the completion for the first time.
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2009-01-13 23:15:46 UTC
The sizing problem is now fixed, I'll attach the updated patch. Note that this depends on GTK+ bug/patch #562701. Otherwise the popup just fails.
Comment 8 Diego Escalante Urrelo (not reading bugmail) 2009-01-13 23:21:47 UTC
Created attachment 126388 [details] [review]
[PATCH] Implement woohoo bar in epiphany

 lib/widgets/ephy-location-entry.c |  109 +++++++++++++++++++++++++------------
 src/ephy-completion-model.c       |   16 ++----
 2 files changed, 80 insertions(+), 45 deletions(-)
Comment 9 Diego Escalante Urrelo (not reading bugmail) 2009-01-15 09:52:08 UTC
The GTK+ bug has been fixed, what do you say if I commit this ;) (and bump GTK+ dep)?
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2009-01-15 22:12:38 UTC
Committed to trunk, hopefully someone will be able to try it so we can decide on it being on 2.26.
Comment 11 Reinout van Schouwen 2009-01-17 13:13:01 UTC
Why can't you commit it to 2-26 and back it out in case of problems?
That way, I can at least try it with the development packages in Cooker...
Comment 12 Diego Escalante Urrelo (not reading bugmail) 2009-01-19 23:18:37 UTC
Now also in 2.26 :-)