After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 541190 - Exits with non-zero return value although nothing bad happened
Exits with non-zero return value although nothing bad happened
Status: RESOLVED FIXED
Product: Tasque
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Johnny Jacob
tasque-maint
Depends on:
Blocks:
 
 
Reported: 2008-07-02 07:47 UTC by Sebastian Dröge (slomo)
Modified: 2008-07-04 12:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Small patch :) .. Return 0 instead of -1. (829 bytes, patch)
2008-07-03 15:10 UTC, Johnny Jacob
committed Details | Review

Description Sebastian Dröge (slomo) 2008-07-02 07:47:12 UTC
Quoting http://bugs.debian.org/488909 :

> I run E17 without a system tray, so when I want to show my tasque window I
> click on the tasque icon in the menu.  
> 
> Tasque (correctly) detects a running tasque instance, and that instance shows
> itself on the current desktop, and the new instance exits with a return code
> of 255 and prints the following message:
> [Debug]: Tasque is already running.  Exiting...
> 
> Unfortunately e17 (correctly from my view) detects that the application failed
> to start and shows a dialog to this effect.
> 
> Tasque really should not return an error code in this case (the debug message
> is fine).
> 
> As a user, it seems to me like tasque started correctly (window appeared -
> that's what I wanted), a running process in the background is irrelevant to
> me.  (As a software developer it seems strange to return an error when there
> really isn't any error seems strange - a running process that couldn't be
> contacted would be an error).

Tasque should, of course, exit with 0 if nothing bad happened :) This is with tasque 0.1.6.
Comment 1 Sandy Armstrong 2008-07-02 16:55:35 UTC
Thanks for the report, good catch.
Comment 2 Johnny Jacob 2008-07-03 15:10:57 UTC
Created attachment 113927 [details] [review]
Small patch :) .. Return 0 instead of -1.
Comment 3 Sandy Armstrong 2008-07-03 15:16:22 UTC
Johnny, feel free to commit.
Comment 4 Johnny Jacob 2008-07-04 12:47:06 UTC
Patch committed to trunk rev 86. Thanks !