After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540781 - Can't reload without bypassing the cache.
Can't reload without bypassing the cache.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks: 562762 563098
 
 
Reported: 2008-06-29 16:26 UTC by Xan Lopez
Modified: 2009-01-08 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[1/9] ephy-embed-utils: add macro to get webkitwebview from embed. (1.59 KB, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review
[2/9] embed: remove ephy_embed_stop_load. (3.87 KB, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review
[3/9] embed: remove ephy_embed_reload. (4.71 KB, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review
[4/9] embed: remove ephy_embed_go_back. (4.55 KB, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review
[5/9] embed: remove ephy_embed_go_forward. (3.81 KB, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review
[6/9] embed: remove ephy_embed_can_go_forward. (4.29 KB, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review
[7/9] embed: remove ephy_embed_can_go_back. (3.71 KB, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review
[8/9] docs: forgot to remove these. (451 bytes, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review
[9/9] embed: remove ephy_embed_print. (4.11 KB, patch)
2008-06-29 16:27 UTC, Xan Lopez
committed Details | Review

Description Xan Lopez 2008-06-29 16:26:30 UTC
And use the webkit APIs.
Comment 1 Xan Lopez 2008-06-29 16:27:23 UTC
Created attachment 113622 [details] [review]
[1/9] ephy-embed-utils: add macro to get webkitwebview from embed.


Will be used in the process to get rid of the embedding abstraction.
---
 embed/Makefile.am        |    1 +
 embed/ephy-embed-utils.h |    4 ++++
 src/ephy-find-toolbar.c  |    3 +--
 3 files changed, 6 insertions(+), 2 deletions(-)
Comment 2 Xan Lopez 2008-06-29 16:27:27 UTC
Created attachment 113623 [details] [review]
[2/9] embed: remove ephy_embed_stop_load.


Use webkit API directly in window-commands.c
---
 doc/reference/epiphany-sections.txt |    1 -
 doc/reference/tmpl/ephy-embed.sgml  |    9 ---------
 embed/ephy-embed.c                  |   13 -------------
 embed/ephy-embed.h                  |    3 ---
 embed/webkit/webkit-embed.c         |    7 -------
 src/epiphany.defs                   |    6 ------
 src/window-commands.c               |    3 ++-
 7 files changed, 2 insertions(+), 40 deletions(-)
Comment 3 Xan Lopez 2008-06-29 16:27:30 UTC
Created attachment 113624 [details] [review]
[3/9] embed: remove ephy_embed_reload.


Use WebKit API directly.
---
 doc/reference/epiphany-sections.txt |    1 -
 doc/reference/tmpl/ephy-embed.sgml  |    9 ---------
 embed/ephy-base-embed.c             |    6 ++++--
 embed/ephy-embed.c                  |   18 ------------------
 embed/ephy-embed.h                  |    5 -----
 embed/webkit/webkit-embed.c         |    8 --------
 src/epiphany.defs                   |    9 ---------
 src/window-commands.c               |    6 +++++-
 8 files changed, 9 insertions(+), 53 deletions(-)
Comment 4 Xan Lopez 2008-06-29 16:27:33 UTC
Created attachment 113625 [details] [review]
[4/9] embed: remove ephy_embed_go_back.


Use WebKit API directly.
---
 doc/reference/epiphany-sections.txt |    1 -
 doc/reference/tmpl/ephy-embed.sgml  |    8 --------
 embed/ephy-embed.c                  |   13 -------------
 embed/ephy-embed.h                  |    3 ---
 embed/webkit/webkit-embed.c         |    7 -------
 src/ephy-navigation-action.c        |    6 +++++-
 src/epiphany.defs                   |    7 -------
 7 files changed, 5 insertions(+), 40 deletions(-)
Comment 5 Xan Lopez 2008-06-29 16:27:36 UTC
Created attachment 113626 [details] [review]
[5/9] embed: remove ephy_embed_go_forward.


Use WebKit API directly.
---
 doc/reference/epiphany-sections.txt |    1 -
 doc/reference/tmpl/ephy-embed.sgml  |    8 --------
 embed/ephy-embed.c                  |   14 --------------
 embed/ephy-embed.h                  |    3 ---
 embed/webkit/webkit-embed.c         |    7 -------
 src/ephy-navigation-action.c        |    2 +-
 src/epiphany.defs                   |    6 ------
 7 files changed, 1 insertions(+), 40 deletions(-)
Comment 6 Xan Lopez 2008-06-29 16:27:39 UTC
Created attachment 113627 [details] [review]
[6/9] embed: remove ephy_embed_can_go_forward.


Use WebKit API directly.
---
 doc/reference/epiphany-sections.txt |    1 -
 doc/reference/tmpl/ephy-embed.sgml  |   10 ----------
 embed/ephy-base-embed.c             |    3 ++-
 embed/ephy-embed.c                  |   13 -------------
 embed/ephy-embed.h                  |    3 ---
 embed/webkit/webkit-embed.c         |    7 -------
 src/epiphany.defs                   |    6 ------
 7 files changed, 2 insertions(+), 41 deletions(-)
Comment 7 Xan Lopez 2008-06-29 16:27:43 UTC
Created attachment 113628 [details] [review]
[7/9] embed: remove ephy_embed_can_go_back.


Use WebKit API directly.
---
 doc/reference/epiphany-sections.txt |    1 -
 doc/reference/tmpl/ephy-embed.sgml  |    9 ---------
 embed/ephy-base-embed.c             |    2 +-
 embed/ephy-embed.c                  |   13 -------------
 embed/ephy-embed.h                  |    3 ---
 embed/webkit/webkit-embed.c         |    7 -------
 src/epiphany.defs                   |    6 ------
 7 files changed, 1 insertions(+), 40 deletions(-)
Comment 8 Xan Lopez 2008-06-29 16:27:46 UTC
Created attachment 113629 [details] [review]
[8/9] docs: forgot to remove these.

 doc/reference/tmpl/ephy-embed.sgml |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
Comment 9 Xan Lopez 2008-06-29 16:27:49 UTC
Created attachment 113630 [details] [review]
[9/9] embed: remove ephy_embed_print.


And use the WebKit API directly.
---
 doc/reference/epiphany-sections.txt |    1 -
 doc/reference/tmpl/ephy-embed.sgml  |    9 ---------
 embed/ephy-embed.c                  |   14 --------------
 embed/ephy-embed.h                  |    3 ---
 embed/webkit/webkit-embed.c         |    7 -------
 src/epiphany.defs                   |    6 ------
 src/window-commands.c               |    2 +-
 7 files changed, 1 insertions(+), 41 deletions(-)
Comment 10 Christian Persch 2008-06-29 17:20:03 UTC
+	/* FIXME: no way to bypass cache when reloading
+	 * with WebKit right now. Old code did:
+	 * ephy_embed_reload (embed, event_with_shift ());
+	 */

File a webkit bug about adding API to do that, and reference it in the comment, please.

Comment 11 Xan Lopez 2008-06-29 18:25:43 UTC
Done. The bug is: https://bugs.webkit.org/show_bug.cgi?id=19815

Changing this bug to track the regression.
Comment 12 Xan Lopez 2009-01-08 13:29:15 UTC
Fixed in trunk.