After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 540525 - [Regression] Continues playing after "Delete From Drive"
[Regression] Continues playing after "Delete From Drive"
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Playback
1.0.0
Other All
: Normal trivial
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 628579 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-06-27 18:28 UTC by lcid-fire
Modified: 2011-06-30 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stops playback when deleting current track from library or disk. (1.67 KB, patch)
2010-11-10 01:07 UTC, Dougal Stanton
committed Details | Review

Description lcid-fire 2008-06-27 18:28:25 UTC
Since 1.0 series a song does not stop playing when it's removed by "Delete From Drive". It keeps on playing which is just annoying because the user surely did not remove the song because it wants to hear the song anymore.

Other information:
Basicly it's restoring the 0.13 behaviour
Comment 1 Alexander Kojevnikov 2010-09-02 02:00:07 UTC
*** Bug 628579 has been marked as a duplicate of this bug. ***
Comment 2 Dougal Stanton 2010-11-10 01:07:40 UTC
Created attachment 174167 [details] [review]
Stops playback when deleting current track from library or disk.

Check to see if the current track is in the set selected-for-deletion. We stop playback entirely in this case; if we choose "next track" we might end up deleting that one immediately afterwards.
Comment 3 Alexander Kojevnikov 2010-11-10 14:58:42 UTC
Review of attachment 174167 [details] [review]:

Committed to master and to stable-1.8, thanks Dougal!
Comment 4 Chow Loong Jin 2010-11-21 14:55:14 UTC
Shouldn't the song be skipped rather than stopping playback entirely? If the next track is to be deleted immediately afterwards, surely Banshee should continue skipping until it finds something not queued for deletion?
Comment 5 Varun 2011-06-30 14:21:24 UTC
I know this is fixed but is there any way to actually enable this "bug"? I just upgraded from 1.6 to 2.0 and sorely miss this feature. Indeed this "bug" was a good reason for me to move to banshee from rhythmbox (default on ubuntu <11.04).

Why I find this useful? Well, often while listening to new music, I like to listen to them fully once and then delete them if I don't much like them. In 1.6, I could easily delete the song whenever I wish, but now I need to wait for it to finish running.

Thanks for all help.